From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbaKGP0j (ORCPT ); Fri, 7 Nov 2014 10:26:39 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:59969 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbaKGP0h (ORCPT ); Fri, 7 Nov 2014 10:26:37 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f5-b7f956d000005ed7-40-545ce4ab9696 Content-transfer-encoding: 8BIT Message-id: <1415373993.31102.29.camel@AMDC1943> Subject: Re: [PATCH v5 0/5] regulator: of: Add initial and suspend modes support From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: Mark Brown , Kukjin Kim , Chanwoo Choi , Olof Johansson , Chris Zhong , Abhilash Kesavan , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Fri, 07 Nov 2014 16:26:33 +0100 In-reply-to: <1415365205-27630-1-git-send-email-javier.martinez@collabora.co.uk> References: <1415365205-27630-1-git-send-email-javier.martinez@collabora.co.uk> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xa7qrn8SEGCy/x2gx9eETNovrX56z Wsw/co7V4ujvAos1f5UsehdcZbO4vGsOm8WM8/uYLE5d/8xmMf/BDmYHLo+/z6+zeOycdZfd Y9OqTjaPKyeaWD3+ztrP4tG3ZRWjx+dNcgHsUVw2Kak5mWWpRfp2CVwZx++sZy04LFIxZdpC 1gbGfQJdjJwcEgImEq/aF7FD2GISF+6tZwOxhQSWMkr03dUCsXkFBCV+TL7H0sXIwcEsIC9x 5FI2SJhZQF1i0rxFzBDlnxklur+HQZQbSGxoOAMWFxYIkDh9YicTiM0mYCyxefkSsPEiAnYS N1Y/BKrhAppzjEli5qp1LCAJFgFViTVX5oHZnEDNX9pms0As8Jf42tfACnKDhICyRGO/2wRG gVlIrpuFcN0sJNctYGRexSiaWppcUJyUnmukV5yYW1yal66XnJ+7iRESDV93MC49ZnWIUYCD UYmH94FITIgQa2JZcWXuIUYJDmYlEd4bx4FCvCmJlVWpRfnxRaU5qcWHGJk4OKUaGOdYfWX+ uPBc/93Xhxb43b/hzFelltSd5roq5qfOdjufqD/yfJGWopmPit78X99hf++El1ZlZ5ex6vcn Fs+tS65E7xN2uGM+96u0qAeb9HkFgVcr+V//f1Tl6rr62xqDmYtmPjNJ1Pm2+NJ7395HM9Vv vzz7XPp9wqtX785bnn79u81f4PLW2cxKLMUZiYZazEXFiQDnjs2/ZAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pią, 2014-11-07 at 14:00 +0100, Javier Martinez Canillas wrote: > Hello Mark, > > This is the fifth version of the series that adds regulator initial > and suspend operating modes support. It relies on the existing work > that added suspend states bindings. The opmodes are parsed by the > regulator core and drivers should only define a translation function > to map between hardware specific to standard modes. > > The series adds a "regulator-initial-mode" property to configure at > startup, the operating mode for the regulators that support changing > its mode during normal operation and a "regulator-mode" property for > the regulators that supports changing its operating mode when the > system enters in a suspend state. These properties were originally > part of Chanwoo Choi's regulator suspend state series [0] but were > removed since there wasn't a way to define the operating modes in a > generic way. > > The generic regulator DT binding doc explains that each device has > to document what their valid operating modes are and drivers must > add a translation function so the core knows how to map the opmodes. > > Older versions of this series were meant to add initial and suspend > modes for the max77802 regulator driver but the feedback was that > this should had been done in a generic way. The latest version was > "[PATCH v4 00/14] Add Maxim 77802 PMIC support" [1] but that series > mixed core changes, bugfixes and new driver features. > > This series instead contains only the patches that add the support > to the regulator core and drivers are only modified when a function > signature is changed to maintain git bisect-ability. > > If the patches are merged, following series will change the drivers > using of_regulator_match() to pass the regulator description in the > match table and another series will add the new opmode feature in > the max77802 regulator driver. > > The series is composed of the following patches: > > Javier Martinez Canillas (5): > regulator: Document binding for initial and suspend modes > regulator: Add function to map modes to struct regulator_desc > regulator: of: Add regulator desc param to > of_get_regulator_init_data() > regulator: of: Pass the regulator description in the match table > regulator: of: Add support for parsing initial and suspend modes I see my previous thoughts were addressed. I had few minor questions about patch 3/5 but still whole patchset looks fine to me. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof