From: Chris Ruffin <cmruffin@gmail.com>
To: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org,
Jes Sorensen <Jes.Sorensen@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Chris Ruffin <cmruffin@gmail.com>
Subject: [PATCH] staging: rtl8723au: change typecast to match type returned by htons()
Date: Mon, 10 Nov 2014 15:07:05 -0500 [thread overview]
Message-ID: <1415650025-16403-1-git-send-email-cmruffin@gmail.com> (raw)
Using a u16 pointer typecast for a result from htons() results in the following warning from sparse:
drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: warning: incorrect type in assignment (different base types)
drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: expected unsigned short [unsigned] [short] [usertype] <noident>
drivers/staging/rtl8723au/core/rtw_xmit.c:1279:36: got restricted __be16 [usertype] <noident>
This patch fixes the issue by using an endian-specific typecast
that will always match the type returned by htons().
Signed-off-by: Chris Ruffin <cmruffin@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
index a0f7e27..44ef55c 100644
--- a/drivers/staging/rtl8723au/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
@@ -1276,7 +1276,7 @@ s32 rtw_put_snap23a(u8 *data, u16 h_proto)
snap->oui[0] = oui[0];
snap->oui[1] = oui[1];
snap->oui[2] = oui[2];
- *(u16 *)(data + SNAP_SIZE) = htons(h_proto);
+ *(__be16 *)(data + SNAP_SIZE) = htons(h_proto);
return SNAP_SIZE + sizeof(u16);
}
--
1.7.10.4
next reply other threads:[~2014-11-10 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 20:07 Chris Ruffin [this message]
2014-11-10 20:21 ` [PATCH] staging: rtl8723au: change typecast to match type returned by htons() Jes Sorensen
2014-11-10 20:28 ` Arend van Spriel
2014-11-10 21:09 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415650025-16403-1-git-send-email-cmruffin@gmail.com \
--to=cmruffin@gmail.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox