linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wanpeng Li <wanpeng.li@linux.intel.com>
To: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@arm.com>
Cc: Kirill Tkhai <ktkhai@parallels.com>,
	linux-kernel@vger.kernel.org,
	Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: [PATCH 2/2] sched/deadline: fix start high-res preemption tick for a non-running task
Date: Tue, 11 Nov 2014 09:52:27 +0800	[thread overview]
Message-ID: <1415670747-58726-2-git-send-email-wanpeng.li@linux.intel.com> (raw)
In-Reply-To: <1415670747-58726-1-git-send-email-wanpeng.li@linux.intel.com>

Queued ticks are scheduled to match the budget, which means the budget 
is overall consumed and the dl task should be throttled. Dl task will 
be replenished immediately if fail to start a dl timer. 

However, the curr maybe not the left most dl task in the rb tree any 
more after this immediately replenished and reschedule is needed. 
Start high-res preemption tick for this upcoming rescheduled dl task 
is not correct. 

This patch fix it by not starting high-res preemption tick for a 
non-running dl task.

Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
---
 kernel/sched/deadline.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 56674f6..2a6a5bb 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1090,7 +1090,8 @@ static void task_tick_dl(struct rq *rq, struct task_struct *p, int queued)
 {
 	update_curr_dl(rq);
 
-	if (hrtick_enabled(rq) && queued && p->dl.runtime > 0)
+	if (hrtick_enabled(rq) && queued && p->dl.runtime > 0 &&
+	    is_leftmost(p, &rq->dl))
 		start_hrtick_dl(rq, p);
 }
 
-- 
1.9.1


  reply	other threads:[~2014-11-11  1:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11  1:52 [PATCH 1/2] sched/deadline: introduce start_hrtick_dl for !CONFIG_SCHED_HRTICK Wanpeng Li
2014-11-11  1:52 ` Wanpeng Li [this message]
2014-11-13  9:37   ` [PATCH 2/2] sched/deadline: fix start high-res preemption tick for a non-running task Juri Lelli
2014-11-13 10:30     ` Wanpeng Li
2014-11-17  9:50       ` Juri Lelli
2014-11-17 11:02         ` Wanpeng Li
2014-11-13  9:31 ` [PATCH 1/2] sched/deadline: introduce start_hrtick_dl for !CONFIG_SCHED_HRTICK Juri Lelli
2014-11-16 12:33 ` [tip:sched/core] sched/deadline: Introduce start_hrtick_dl() " tip-bot for Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415670747-58726-2-git-send-email-wanpeng.li@linux.intel.com \
    --to=wanpeng.li@linux.intel.com \
    --cc=juri.lelli@arm.com \
    --cc=ktkhai@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).