From: Johannes Berg <johannes@sipsolutions.net>
To: Kees Cook <keescook@google.com>
Cc: Greg Kroah-Hartmann <gregkh@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] devcoredump: provide a one-way disable function
Date: Thu, 13 Nov 2014 23:36:25 +0100 [thread overview]
Message-ID: <1415918185.19075.1.camel@sipsolutions.net> (raw)
In-Reply-To: <CAGXu5jL8CBPXyiZM+AQpNUOvF=rQxay7ozmEaLuRL8WSiRQ2tA@mail.gmail.com> (sfid-20141113_225649_251686_3A86B085)
On Thu, 2014-11-13 at 13:56 -0800, Kees Cook wrote:
> > + /*
> > + * This essentially makes the attribute write-once, since you can't
> > + * go back to not having it disabled. This is intentional, it serves
> > + * as a system lockdown feature.
> > + */
> > + if (tmp != 1)
> > + return -EINVAL;
>
> Just a nit, but writing "0" is valid if devcd_disabled = false?
I thought about that too, but what would the point be? The only
operation you ever can/want to do is writing "1" to it to disable the
framework.
johannes
next prev parent reply other threads:[~2014-11-13 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 21:16 [PATCH] devcoredump: provide a one-way disable function Johannes Berg
2014-11-13 21:56 ` Kees Cook
2014-11-13 22:36 ` Johannes Berg [this message]
2014-11-13 23:35 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415918185.19075.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gregkh@linux-foundation.org \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox