From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Daniel Borkmann <dborkman@redhat.com>,
Eric Dumazet <edumazet@google.com>,
linux-api@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command
Date: Fri, 14 Nov 2014 13:11:11 +0100 [thread overview]
Message-ID: <1415967071.15154.9.camel@localhost> (raw)
In-Reply-To: <1415929010-9361-2-git-send-email-ast@plumgrid.com>
On Do, 2014-11-13 at 17:36 -0800, Alexei Starovoitov wrote:
> the current meaning of BPF_MAP_UPDATE_ELEM syscall command is:
> either update existing map element or create a new one.
> Initially the plan was to add a new command to handle the case of
> 'create new element if it didn't exist', but 'flags' style looks
> cleaner and overall diff is much smaller (more code reused), so add 'flags'
> attribute to BPF_MAP_UPDATE_ELEM command with the following meaning:
> #define BPF_ANY 0 /* create new element or update existing */
> #define BPF_NOEXIST 1 /* create new element if it didn't exist */
> #define BPF_EXIST 2 /* update existing element */
Would a cmpxchg-alike function be handy here?
Bye,
Hannes
next prev parent reply other threads:[~2014-11-14 12:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 1:36 [PATCH v2 net-next 0/7] implementation of eBPF maps Alexei Starovoitov
2014-11-14 1:36 ` [PATCH v2 net-next 1/7] bpf: add 'flags' attribute to BPF_MAP_UPDATE_ELEM command Alexei Starovoitov
2014-11-14 12:11 ` Hannes Frederic Sowa [this message]
2014-11-14 15:33 ` Alexei Starovoitov
2014-11-14 16:06 ` Hannes Frederic Sowa
2014-11-14 16:31 ` Alexei Starovoitov
2014-11-14 1:36 ` [PATCH v2 net-next 2/7] bpf: add hashtable type of eBPF maps Alexei Starovoitov
2014-11-14 1:36 ` [PATCH v2 net-next 3/7] bpf: add array " Alexei Starovoitov
2014-11-14 1:36 ` [PATCH v2 net-next 4/7] bpf: fix BPF_MAP_LOOKUP_ELEM command return code Alexei Starovoitov
2014-11-14 1:36 ` [PATCH v2 net-next 5/7] bpf: add a testsuite for eBPF maps Alexei Starovoitov
2014-11-14 1:36 ` [PATCH v2 net-next 6/7] bpf: allow eBPF programs to use maps Alexei Starovoitov
2014-11-16 19:04 ` David Miller
2014-11-16 21:24 ` Alexei Starovoitov
2014-11-16 21:34 ` David Miller
2014-11-14 1:36 ` [PATCH v2 net-next 7/7] bpf: remove test map scaffolding and user proper types Alexei Starovoitov
2014-11-18 20:39 ` [PATCH v2 net-next 0/7] implementation of eBPF maps David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415967071.15154.9.camel@localhost \
--to=hannes@stressinduktion.org \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox