From: Joe Perches <joe@perches.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/8] of: Use vargs in __of_node_alloc
Date: Thu, 20 Nov 2014 17:43:05 -0800 [thread overview]
Message-ID: <1416534185.6651.30.camel@perches.com> (raw)
In-Reply-To: <1416533715-9758-2-git-send-email-grant.likely@linaro.org>
On Fri, 2014-11-21 at 01:35 +0000, Grant Likely wrote:
> The overlay code needs to construct a new full_name from the parent name
> and the node name, but the current method has to allocate and then free
> an temporary string which is wasteful. Fix this problem by using vargs
> to pass in a format and arguments into __of_node_alloc().
[]
> diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h
[]
> @@ -61,7 +61,7 @@ static inline int of_property_notify(int action, struct device_node *np,
> * own the devtree lock or work on detached trees only.
> */
> struct property *__of_prop_dup(const struct property *prop, gfp_t allocflags);
> -struct device_node *__of_node_alloc(const char *full_name, gfp_t allocflags);
Please add
__printf(1, 2)
> +struct device_node *__of_node_alloc(const char *fmt, ...);
next prev parent reply other threads:[~2014-11-21 1:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 1:35 [PATCH 0/8] of: DT Overlay patches to be merged Grant Likely
2014-11-21 1:35 ` [PATCH 1/8] of: Use vargs in __of_node_alloc Grant Likely
2014-11-21 1:43 ` Joe Perches [this message]
2014-11-24 22:26 ` Grant Likely
2014-11-21 1:35 ` [PATCH 2/8] of: Refactor __of_node_alloc() into __of_node_dup() Grant Likely
2014-11-21 1:35 ` [PATCH 3/8] of/resolver: Switch to new local fixups format Grant Likely
2014-11-21 1:35 ` [PATCH 4/8] of: Add of_reconfig_get_state_change() of notifier helper Grant Likely
2014-11-21 1:35 ` [PATCH 5/8] of/overlay: Introduce DT overlay support Grant Likely
2014-11-26 13:11 ` Paul Bolle
2014-11-26 15:18 ` Grant Likely
2014-11-26 16:57 ` Paul Bolle
2014-11-28 0:07 ` Grant Likely
2014-11-28 8:57 ` Paul Bolle
2014-11-21 1:35 ` [PATCH 6/8] of/platform: Add OF_DYNAMIC notifier handler Grant Likely
2014-11-21 1:35 ` [PATCH 7/8] of/overlay: Add overlay unittests Grant Likely
2014-11-21 1:35 ` [PATCH 8/8] of: Add debug output for OF_RECONFIG notifiers Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416534185.6651.30.camel@perches.com \
--to=joe@perches.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox