linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Kochetkov <al.kochet@gmail.com>
To: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>, Wolfram Sang <wsa@the-dreams.de>,
	Kevin Hilman <khilman@kernel.org>,
	Alexander Kochetkov <al.kochet@gmail.com>
Subject: [PATCH v2] omap: i2c: don't check bus state IP rev3.3 and earlier
Date: Tue, 25 Nov 2014 02:20:55 +0400	[thread overview]
Message-ID: <1416867655-22232-1-git-send-email-al.kochet@gmail.com> (raw)
In-Reply-To: <20141124210809.GG2817@atomide.com>

Commit 903c3859f77f9b0aace551da03267ef7a211dbc4 ("i2c: omap: implement
workaround for handling invalid BB-bit values") introduce the error result
in boot test fault on OMAP3530 boards

The patch fix the error (disable i2c bus test for OMAP3530).

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
Fixes: 903c3859f77f9b0aace551da03267ef7a211dbc4
Reported-by: Kevin Hilman <khilman@kernel.org>
Tested-by: Tony Lindgren <tony@atomide.com>

---
 drivers/i2c/busses/i2c-omap.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 5d92d0e..4563200 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -344,8 +344,10 @@ static int omap_i2c_reset(struct omap_i2c_dev *dev)
 		/* SYSC register is cleared by the reset; rewrite it */
 		omap_i2c_write_reg(dev, OMAP_I2C_SYSC_REG, sysc);
 
-		/* Schedule I2C-bus monitoring on the next transfer */
-		dev->bb_valid = 0;
+		if (dev->rev > OMAP_I2C_REV_ON_3430_3530) {
+			/* Schedule I2C-bus monitoring on the next transfer */
+			dev->bb_valid = 0;
+		}
 	}
 
 	return 0;
@@ -460,7 +462,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
 	dev->scllstate = scll;
 	dev->sclhstate = sclh;
 
-	if (dev->rev < OMAP_I2C_OMAP1_REV_2) {
+	if (dev->rev <= OMAP_I2C_REV_ON_3430_3530) {
 		/* Not implemented */
 		dev->bb_valid = 1;
 	}
-- 
1.7.9.5


  reply	other threads:[~2014-11-24 22:21 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 21:28 [RFC 0/4] i2c: omap: patch series related to multimaster mode Alexander Kochetkov
2014-11-20 21:28 ` [PATCH 1/4] i2c: omap: cleanup register definitions Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-20 21:28 ` [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-22 13:23     ` Wolfram Sang
2014-11-22 14:06       ` Alexander Kochetkov
2014-11-22 18:02         ` Wolfram Sang
2014-11-23  4:43           ` Felipe Balbi
2014-11-23 13:18             ` Alexander Kochetkov
2014-11-24 19:08               ` Felipe Balbi
2014-11-24 19:09   ` Felipe Balbi
2014-11-20 21:28 ` [PATCH 3/4] i2c: omap: don't reset controller if Arbitration Lost detected Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-21 18:11   ` Wolfram Sang
2014-11-21 22:51   ` [PATCH v2 " Alexander Kochetkov
2014-11-22  1:07     ` Felipe Balbi
2014-11-20 21:28 ` [PATCH 4/4] i2c: omap: add notes related to i2c multimaster mode Alexander Kochetkov
2014-11-21 16:08   ` Felipe Balbi
2014-11-22 19:47 ` [PATCH v3 0/4] i2c: omap: patch series related to " Alexander Kochetkov
2014-11-22 19:47   ` [PATCH v3 1/4] i2c: omap: cleanup register definitions Alexander Kochetkov
2014-11-22 19:47   ` [PATCH v3 2/4] i2c: omap: implement workaround for handling invalid BB-bit values Alexander Kochetkov
2014-11-24 19:08     ` Kevin Hilman
2014-11-24 19:10       ` Felipe Balbi
2014-11-24 19:13         ` Wolfram Sang
2014-11-24 19:25           ` Tony Lindgren
2014-11-24 19:39       ` Alexander Kochetkov
2014-11-24 19:47         ` Tony Lindgren
2014-11-24 20:05           ` Alexander Kochetkov
2014-11-25  0:09             ` Alexander Kochetkov
2014-11-25 15:41               ` Tony Lindgren
2014-11-24 21:08           ` Alexander Kochetkov
2014-11-26 22:30           ` Alexander Kochetkov
2014-11-24 20:33     ` [PATCH] omap: i2c: don't check bus state IP rev3.3 and earlier Alexander Kochetkov
2014-11-24 21:08       ` Tony Lindgren
2014-11-24 22:20         ` Alexander Kochetkov [this message]
2014-11-25 14:19           ` [PATCH v2] " Wolfram Sang
2014-11-25 14:38             ` Alexander Kochetkov
2014-11-25 19:13               ` Kevin Hilman
2014-11-26 19:26                 ` Alexander Kochetkov
2014-11-26 21:33                   ` Kevin Hilman
2014-11-25 19:12           ` Kevin Hilman
2014-11-26 19:05     ` [RFC] i2c: omap: TEST: do IP reset during probe Alexander Kochetkov
2014-11-26 21:25       ` Kevin Hilman
2014-11-28 22:13         ` Tony Lindgren
2014-11-28 23:25           ` Alexander Kochetkov
2014-11-29 22:06             ` Tony Lindgren
2014-11-29  2:14           ` Alexander Kochetkov
2014-11-22 19:47   ` [PATCH v3 3/4] i2c: omap: don't reset controller if Arbitration Lost detected Alexander Kochetkov
2014-11-22 19:47   ` [PATCH v3 4/4] i2c: omap: add notes related to i2c multimaster mode Alexander Kochetkov
2014-11-22 21:08   ` [PATCH v3 0/4] i2c: omap: patch series related to " Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416867655-22232-1-git-send-email-al.kochet@gmail.com \
    --to=al.kochet@gmail.com \
    --cc=balbi@ti.com \
    --cc=khilman@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).