linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 07/12] perf tools: Allow to force redirect pr_debug to stderr.
Date: Tue, 25 Nov 2014 10:22:05 -0300	[thread overview]
Message-ID: <1416921730-5063-8-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1416921730-5063-1-git-send-email-acme@kernel.org>

From: Andi Kleen <ak@linux.intel.com>

When debugging the tui browser I find it useful to redirect the debug
log into a file. Currently it's always forced to the message line.

Add an option to force it to stderr. Then it can be easily redirected.

Example:

  [root@zoo ~]# perf --debug stderr report -vv 2> /tmp/debug
  [root@zoo ~]# tail /tmp/debug
  dso open failed, mmap: No such file or directory
  dso open failed, mmap: No such file or directory
  dso open failed, mmap: No such file or directory
  dso open failed, mmap: No such file or directory
  dso open failed, mmap: No such file or directory
  Using /root/.debug/.build-id/4e/841948927029fb650132253642d5dbb2c1fb93 for symbols
  Failed to open /tmp/perf-8831.map, continuing without symbols
  Failed to open /tmp/perf-12721.map, continuing without symbols
  Failed to open /tmp/perf-6966.map, continuing without symbols
  Failed to open /tmp/perf-8802.map, continuing without symbols
  [root@zoo ~]#

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1416605880-25055-2-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/debug.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c
index ba357f3226c6..ad60b2f20258 100644
--- a/tools/perf/util/debug.c
+++ b/tools/perf/util/debug.c
@@ -19,13 +19,14 @@
 int verbose;
 bool dump_trace = false, quiet = false;
 int debug_ordered_events;
+static int redirect_to_stderr;
 
 static int _eprintf(int level, int var, const char *fmt, va_list args)
 {
 	int ret = 0;
 
 	if (var >= level) {
-		if (use_browser >= 1)
+		if (use_browser >= 1 && !redirect_to_stderr)
 			ui_helpline__vshow(fmt, args);
 		else
 			ret = vfprintf(stderr, fmt, args);
@@ -145,6 +146,7 @@ static struct debug_variable {
 } debug_variables[] = {
 	{ .name = "verbose",		.ptr = &verbose },
 	{ .name = "ordered-events",	.ptr = &debug_ordered_events},
+	{ .name = "stderr",		.ptr = &redirect_to_stderr},
 	{ .name = NULL, }
 };
 
-- 
1.9.3


  parent reply	other threads:[~2014-11-25 13:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 13:21 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-11-25 13:21 ` [PATCH 01/12] perf hists browser: Print overhead percent value for first-level callchain Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 02/12] perf tools: Collapse first level callchain entry if it has sibling Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 03/12] perf callchain: Enable printing the srcline in the history Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 04/12] perf symbols: Move bfd_demangle stubbing to its only user Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 05/12] perf callchain: Make get_srcline fall back to sym+offset Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 06/12] perf tools: Fix segfault due to invalid kernel dso access Arnaldo Carvalho de Melo
2014-11-25 13:22 ` Arnaldo Carvalho de Melo [this message]
2014-11-25 13:22 ` [PATCH 08/12] perf evsel: Introduce perf_evsel__compute_deltas function Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 09/12] perf evsel: Introduce perf_counts_values__scale function Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 10/12] perf evsel: Introduce perf_evsel__read_cb function Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 11/12] perf tools: Add per-pkg format file parsing Arnaldo Carvalho de Melo
2014-11-25 13:22 ` [PATCH 12/12] perf tools: Add snapshot " Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416921730-5063-8-git-send-email-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).