public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Takashi Iwai <tiwai@suse.de>, Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	pgynther@google.com, linux-bluetooth@vger.kernel.org
Subject: Re: bluetooth related firmware loader spew on resume.
Date: Wed, 26 Nov 2014 15:16:35 +0100	[thread overview]
Message-ID: <1417011395.5928.4.camel@linux-0dmf.site> (raw)
In-Reply-To: <0E1D95E7-64D2-4BEA-AFAA-4B119838F24E@holtmann.org>

On Wed, 2014-11-26 at 23:05 +0900, Marcel Holtmann wrote:
> Hi Oliver,
> 
> >> In order to paper over this, we may also remember the failing firmware
> >> and avoid loading it.  This might be an easer way than the endless
> >> fight against UMH race...
> > 
> > 
> > the full fix would be to implement reset_resume() for btusb.
> > It seems to me that setup() should be split in two methods,
> > one to request the firmware from user space and the second
> > to transfer it to the device. reset_resume() would just need
> > to repeat the second operation.
> 
> so when you do hci_register_dev, then hdev->setup is only called once. I really mean only once per lifetime of the hci_dev. So you would need to unregister the hci_dev first before hdev->setup will ever be called again. So I am not sure this is actually the problem here. The problem here is entirely within request_firmware() unless of course we run through the USB probe handlers again. Which I do not see happening here.

It seems most likely to me that probing is indeed done again.
btusb does not implement reset_resume(). If power goes away
as is usual on S3/4 the device is reenumerated. The original
trace has a call to btusb_setup_bcm_patchram().
What else could be happening?

	Regards
		Oliver




  parent reply	other threads:[~2014-11-26 14:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 18:12 bluetooth related firmware loader spew on resume Dave Jones
2014-11-25 16:40 ` Takashi Iwai
2014-11-26  5:15   ` Marcel Holtmann
2014-11-26  8:52     ` Takashi Iwai
2014-11-26 10:10       ` Oliver Neukum
2014-11-26 10:31         ` Takashi Iwai
2014-11-26 10:43           ` Oliver Neukum
2014-11-26 10:53             ` Takashi Iwai
2014-11-26 14:08               ` Marcel Holtmann
2014-11-26 14:23               ` Oliver Neukum
2014-11-26 14:31                 ` Takashi Iwai
2014-11-26 14:38                   ` Oliver Neukum
2014-11-26 14:05         ` Marcel Holtmann
2014-11-26 14:12           ` Takashi Iwai
2014-11-26 14:27             ` Oliver Neukum
2014-11-26 15:21               ` Takashi Iwai
2014-11-27 14:43                 ` Takashi Iwai
2014-11-26 14:16           ` Oliver Neukum [this message]
2014-11-26 14:56 ` Mihai Donțu
2014-11-26 15:19   ` Takashi Iwai
2014-11-26 15:26     ` Mihai Donțu
2014-11-26 15:27       ` Takashi Iwai
2014-11-26 17:42         ` Arend van Spriel
2014-11-26 18:13           ` Takashi Iwai
2014-11-27  8:59             ` Arend van Spriel
2014-11-27  9:17               ` Takashi Iwai
2014-11-27  9:29                 ` Arend van Spriel
2014-11-27  9:46                   ` Arend van Spriel
2014-11-27 10:09                     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417011395.5928.4.camel@linux-0dmf.site \
    --to=oneukum@suse.de \
    --cc=davej@redhat.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=pgynther@google.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox