From: Flora Fu <flora.fu@mediatek.com>
To: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@linaro.org>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
<linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
<srv_heupstream@mediatek.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Dongdong Cheng <dongdong.cheng@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
Flora Fu <flora.fu@mediatek.com>
Subject: Re: [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD
Date: Wed, 3 Dec 2014 16:40:18 +0800 [thread overview]
Message-ID: <1417596018.24267.62.camel@mtksdaap41> (raw)
In-Reply-To: <20141201114717.GD15845@x1>
On Mon, 2014-12-01 at 11:47 +0000, Lee Jones wrote:
> On Fri, 28 Nov 2014, Flora Fu wrote:
>
> > + if (!mt6397)
> > + return -ENOMEM;
> > +
> > + mt6397->dev = &pdev->dev;
>
> Is this used else where? If not, I think you can remove it.
No one is used it in this patch sets but it will be used for irq
functions to get irq id or print logs for error case in the future.
Can I keep it in the patch?
>
> > + mt6397->regmap = wrp->regmap;
> > + platform_set_drvdata(pdev, mt6397);
>
> Then you can platform_set_drvdata(pdev, regmap);
>
> Although I don't see this being used either. Is it used in the child
> devices?
>
Yes, it is used to provide regmap handle for its child device. In the
patch set, regulator uses it.
Thanks,
Flora
next prev parent reply other threads:[~2014-12-03 8:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1417146874-5232-1-git-send-email-flora.fu@mediatek.com>
[not found] ` <1417146874-5232-4-git-send-email-flora.fu@mediatek.com>
2014-11-28 15:22 ` [PATCH v2 3/8] regulator: MT6397: Add support for MT6397 regulator Mark Brown
[not found] ` <1417402305.30873.78.camel@mtksdaap41>
2014-12-01 16:12 ` Mark Brown
[not found] ` <1417146874-5232-9-git-send-email-flora.fu@mediatek.com>
2014-11-28 15:30 ` [PATCH v2 8/8] ARM: dts: mt8135: " Mark Brown
[not found] ` <1417403967.9547.2.camel@mtksdaap41>
2014-12-01 6:40 ` Sascha Hauer
2014-12-01 11:16 ` Mark Brown
[not found] ` <1417146874-5232-7-git-send-email-flora.fu@mediatek.com>
2014-11-28 15:30 ` [PATCH v2 6/8] dt-bindings: Add document " Mark Brown
[not found] ` <1417146874-5232-2-git-send-email-flora.fu@mediatek.com>
2014-11-28 15:32 ` [PATCH v2 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC Mark Brown
2014-12-01 7:04 ` [PATCH v2 0/8] Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Sascha Hauer
[not found] ` <1417146874-5232-3-git-send-email-flora.fu@mediatek.com>
2014-12-01 11:47 ` [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD Lee Jones
2014-12-03 8:40 ` Flora Fu [this message]
2014-12-03 9:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417596018.24267.62.camel@mtksdaap41 \
--to=flora.fu@mediatek.com \
--cc=broonie@kernel.org \
--cc=dongdong.cheng@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox