From: Oliver Neukum <oneukum@suse.de>
To: gyungoh@gmail.com
Cc: sameo@linux.intel.com, lee.jones@linaro.org,
grant.likely@linaro.org, robh+dt@kernel.org, jg1.han@samsung.com,
cooloney@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
trivial@kernel.org, akpm@linux-foundation.org, jic23@kernel.org,
thomas.petazzoni@free-electrons.com, ktsai@capellamicro.com,
hs@denx.de, stwiss.opensource@diasemi.com,
matti.vaittinen@nsn.com, broonie@kernel.org,
jason@lakedaemon.net, heiko@sntech.de, shawn.guo@freescale.com,
florian.vaussard@epfl.ch, andrew@lunn.ch,
antonynpavlov@gmail.com, hytszk@gmail.com, plagnioj@jcrosoft.com,
tomi.valkeinen@ti.com, jack.yoo@skyworksinc.com,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver
Date: Wed, 03 Dec 2014 11:02:29 +0100 [thread overview]
Message-ID: <1417600949.12511.7.camel@linux-0dmf.site> (raw)
In-Reply-To: <1417590332-4912-3-git-send-email-jack.yoo@skyworksinc.com>
On Wed, 2014-12-03 at 16:05 +0900, gyungoh@gmail.com wrote:
> +static ssize_t sky81452_bl_store_enable(struct device *dev,
> + struct device_attribute *attr, const char *buf, size_t
> count)
> +{
> + struct regmap *regmap = bl_get_data(to_backlight_device(dev));
> + unsigned long value;
> + int ret;
> +
> + ret = kstrtoul(buf, 16, &value);
> + if (IS_ERR_VALUE(ret))
> + return ret;
> +
> + ret = regmap_update_bits(regmap, SKY81452_REG1, SKY81452_EN,
> + value << CTZ(SKY81452_EN));
No range checking for value?
> + if (IS_ERR_VALUE(ret))
> + return ret;
> +
> + return count;
> +}
Regards
Oliver
--
Oliver Neukum <oneukum@suse.de>
next prev parent reply other threads:[~2014-12-03 10:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 7:05 [PATCH v10 0/6] Add Skyworks SKY81452 device drivers gyungoh
2014-12-03 7:05 ` [PATCH v10 1/6] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-12-03 7:05 ` [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-12-03 7:13 ` Jingoo Han
2014-12-03 10:02 ` Oliver Neukum [this message]
2014-12-04 2:04 ` Gyungoh Yoo
2014-12-03 7:05 ` [PATCH v10 3/6] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-12-03 7:05 ` [PATCH v10 4/6] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-12-03 7:05 ` [PATCH v10 5/6] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-12-03 7:05 ` [PATCH v10 6/6] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
-- strict thread matches above, loose matches on Subject: below --
2014-12-18 5:47 [PATCH v10 0/6] Add Skyworks SKY81452 device drivers gyungoh
2014-12-18 5:47 ` [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-12-18 6:09 ` Jingoo Han
2014-12-18 6:13 ` Gyungoh Yoo
2015-01-07 2:19 [PATCH v10 0/6] Add Skyworks SKY81452 device drivers gyungoh
2015-01-07 2:19 ` [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2015-01-23 6:28 [PATCH v10 0/6] Add Skyworks SKY81452 device drivers gyungoh
2015-01-23 6:28 ` [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417600949.12511.7.camel@linux-0dmf.site \
--to=oneukum@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=antonynpavlov@gmail.com \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gyungoh@gmail.com \
--cc=heiko@sntech.de \
--cc=hs@denx.de \
--cc=hytszk@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jack.yoo@skyworksinc.com \
--cc=jason@lakedaemon.net \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@nsn.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@freescale.com \
--cc=stwiss.opensource@diasemi.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tomi.valkeinen@ti.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox