From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org,
Jeremiah Mahler <jmmahler@gmail.com>,
weiyj_lk@163.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: drm/i915: Fix missing unlock on error in i915_gem_init_hw()
Date: Fri, 5 Dec 2014 14:17:02 +0200 [thread overview]
Message-ID: <1417781823-23283-1-git-send-email-jani.nikula@intel.com> (raw)
In-Reply-To: <20141205013911.GA1510@hudson.localdomain>
On Fri, 05 Dec 2014, Jeremiah Mahler <jmmahler@gmail.com> wrote:
> There are other places in i915_gem_init_hw() where it returns without
> unlocking the mutex. Why is it only necessary here and not any of the
> other places?
There's probably some rebase/merge confusion going on. The following
patch is against drm-intel-next-queued where the problem is
present. Thanks for reporting this.
BR,
Jani.
Jani Nikula (1):
drm/i915: release struct_mutex on the i915_gem_init_hw fail path
drivers/gpu/drm/i915/i915_gem.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
--
2.1.3
next prev parent reply other threads:[~2014-12-05 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 0:55 [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw() weiyj_lk
2014-12-05 1:39 ` Jeremiah Mahler
2014-12-05 12:17 ` Jani Nikula [this message]
2014-12-05 12:17 ` Jani Nikula
2014-12-05 12:17 ` [PATCH] drm/i915: release struct_mutex on the i915_gem_init_hw fail path Jani Nikula
2014-12-05 13:03 ` Jeremiah Mahler
2014-12-05 14:04 ` [Intel-gfx] " Daniel Vetter
2014-12-05 13:21 ` [Intel-gfx] [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw() Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417781823-23283-1-git-send-email-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj_lk@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox