From: Joe Perches <joe@perches.com>
To: Asaf Vertz <asaf.vertz@tandemg.com>
Cc: dmitry.torokhov@gmail.com, LW@KARO-electronics.de,
B38611@freescale.com, maksqwe1@ukr.net, jg1.han@samsung.com,
linux@rasmusvillemoes.dk, fabf@skynet.be,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: edt-ft5x06: fixed a macro coding style issue
Date: Mon, 08 Dec 2014 22:44:20 -0800 [thread overview]
Message-ID: <1418107460.15957.9.camel@perches.com> (raw)
In-Reply-To: <20141209063456.GA15121@ubuntu>
On Tue, 2014-12-09 at 08:34 +0200, Asaf Vertz wrote:
> Fixed a coding style error, macros with complex values should be
> enclosed in parentheses.
[]
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
[]
> @@ -849,10 +849,11 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
> return 0;
> }
>
> -#define EDT_ATTR_CHECKSET(name, reg) \
> +#define EDT_ATTR_CHECKSET(name, reg) { \
> if (pdata->name >= edt_ft5x06_attr_##name.limit_low && \
> pdata->name <= edt_ft5x06_attr_##name.limit_high) \
> - edt_ft5x06_register_write(tsdata, reg, pdata->name)
> + edt_ft5x06_register_write(tsdata, reg, pdata->name); \
> +}
Any time you see a naked if (foo) bar in a macro
prefer to use a do while (0) like;
#define EDT_ATTR_CHECKSET(name, reg) \
do { \
if (pdata->name >= edt_ft5x06_attr_##name.limit_low && \
pdata->name <= edt_ft5x06_attr_##name.limit_high) \
edt_ft5x06_register_write(tsdata, reg, pdata->name); \
while (0)
next prev parent reply other threads:[~2014-12-09 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 6:34 [PATCH] input: edt-ft5x06: fixed a macro coding style issue Asaf Vertz
2014-12-09 6:44 ` Joe Perches [this message]
2014-12-09 7:51 ` Asaf Vertz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418107460.15957.9.camel@perches.com \
--to=joe@perches.com \
--cc=B38611@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=asaf.vertz@tandemg.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fabf@skynet.be \
--cc=jg1.han@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maksqwe1@ukr.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox