From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] regulator: s2mps11: Fix dwmmc failure on Gear 2
Date: Thu, 11 Dec 2014 14:20:46 +0100 [thread overview]
Message-ID: <1418304046.29711.2.camel@AMDC1943> (raw)
In-Reply-To: <20141211131305.GW11764@sirena.org.uk>
On czw, 2014-12-11 at 13:13 +0000, Mark Brown wrote:
> On Thu, Dec 11, 2014 at 01:39:11PM +0100, Krzysztof Kozlowski wrote:
> > Invalid buck4 configuration in S2MPS14 regulators caused boot failure on
> > Gear 2 (dwmmc_exynos):
>
> What is invalid about the configuration and how is this change intended
> to fix it?
Wrong number was used for buck4 linear_min_sel. It should be
S2MPS14_BUCK4_START_SEL (0x40) instead of S2MPS14_BUCK1235_START_SEL
(0x20).
Issue is fixed by using proper number.
I'll resend the patch with extended description.
>
> > [ 3.569137] EXT4-fs (mmcblk0p15): mounted filesystem with ordered data mode. Opts: (null)
> > [ 3.571716] VFS: Mounted root (ext4 filesystem) readonly on device 179:15.
> > [ 3.580836] devtmpfs: mounted
> > [ 3.582033] Freeing unused kernel memory: 284K (c05b4000 - c05fb000)
> > [ 3.629842] mmcblk0: error -110 sending status command, retrying
> > [ 3.630244] mmcblk0: error -110 sending status command, retrying
>
> Please don't include large log sections in commit messages, edit them
> down to any relevant information. They get very large and obscure the
> relevant content in the messages.
I'll trim it.
Best regards,
Krzysztof
prev parent reply other threads:[~2014-12-11 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 12:39 [PATCH] regulator: s2mps11: Fix dwmmc failure on Gear 2 Krzysztof Kozlowski
2014-12-11 13:13 ` Mark Brown
2014-12-11 13:20 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418304046.29711.2.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sbkim73@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox