Re: default enable sparse __CHECK_ENDIAN__ (was: Re: [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver)

Marcel Holtmann
2014-12-11T11:18:52Z

Hi Joe,

>>> Are you referring to the static code analyser sparse that is invoked
>>> through?
>> You have to explicitly enable endian checking, it's not on by
>> default.
>
> There don't seem to be thousands of warnings anymore.
>
> Maybe it's time to default enable it when using C=?
>
> from: Documentation/sparse.txt:
>
> The optional make variable CF can be used to pass arguments to sparse. The
> build system passes -Wbitwise to sparse automatically. To perform endianness
> checks, you may define __CHECK_ENDIAN__:
>
> make C=2 CF="-D__CHECK_ENDIAN__"
>
> These checks are disabled by default as they generate a host of warnings.

actually a few subsystems use this in their Makefile:

subdir-ccflags-y += -D__CHECK_ENDIAN__

We could start with that to enable endian checks by default in various places.

Regards

Marcel