From: Eddie Huang <eddie.huang@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: <wim@iguana.be>, <robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <grant.likely@linaro.org>,
<heiko@sntech.de>, <yingjoe.chen@gmail.com>,
<linux-kernel@vger.kernel.org>, <ibanezchen@gmail.com>,
<greta.zhang@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] watchdog: Add driver for Mediatek watchdog
Date: Mon, 15 Dec 2014 11:37:31 +0800 [thread overview]
Message-ID: <1418614651.18671.3.camel@mtksdaap41> (raw)
In-Reply-To: <1418395859-32209-2-git-send-email-matthias.bgg@gmail.com>
Hi,
On Fri, 2014-12-12 at 15:50 +0100, Matthias Brugger wrote:
> This patch adds a driver for the Mediatek SoC integrated
> watchdog. This driver supports watchdog and software reset
> for mt65xx and mt81xx SoCs.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> +static int mtk_reset_handler(struct notifier_block *this, unsigned long mode,
> + void *cmd)
> +{
> + struct mtk_wdt_dev *mtk_wdt = container_of(this,
> + struct mtk_wdt_dev,
> + restart_handler);
> + void __iomem *wdt_base = mtk_wdt->wdt_base;
> + u32 reg;
> +
> + /* Reset system */
> + writel(WDT_SWRST_KEY, wdt_base + WDT_SWRST);
> +
> + while (1) {
> + mdelay(5);
> + writel(WDT_SWRST_KEY, wdt_base + WDT_SWRST);
> + }
> + return NOTIFY_DONE;
> +
> +}
Build warning
../drivers/watchdog/mtk_wdt.c:78:6: warning: unused variable
'reg' [-Wunused-variable]
next prev parent reply other threads:[~2014-12-15 3:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 14:50 [PATCH v2 0/2] ARM: mediatek: Add watchdog driver Matthias Brugger
2014-12-12 14:50 ` [PATCH v2 1/2] watchdog: Add driver for Mediatek watchdog Matthias Brugger
2014-12-13 2:08 ` Chen-Yu Tsai
2014-12-13 15:44 ` Guenter Roeck
2014-12-15 3:37 ` Eddie Huang [this message]
2014-12-12 14:50 ` [PATCH v2 2/2] ARM: mediatek: dts: Add bindings for watchdog Matthias Brugger
2014-12-13 15:45 ` Guenter Roeck
2014-12-16 16:14 ` Matthias Brugger
2014-12-16 16:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418614651.18671.3.camel@mtksdaap41 \
--to=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=greta.zhang@mediatek.com \
--cc=heiko@sntech.de \
--cc=ibanezchen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wim@iguana.be \
--cc=yingjoe.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox