Re: [PATCH 05/18] blackfin/uaccess: fix sparse errors

Steven Miao
2014-12-18T03:11:35Z

On Mon, Dec 15, 2014 at 12:52 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> virtio wants to read bitwise types from userspace using get_user. At the
> moment this triggers sparse errors, since the value is passed through an
> integer.
>
> Fix that up using __force.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> arch/blackfin/include/asm/uaccess.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/include/asm/uaccess.h b/arch/blackfin/include/asm/uaccess.h
> index 57701c3..6a46e7d 100644
> --- a/arch/blackfin/include/asm/uaccess.h
> +++ b/arch/blackfin/include/asm/uaccess.h
> @@ -147,7 +147,7 @@ static inline int bad_user_access_length(void)
> } \
> } else \
> _err = -EFAULT; \
> - x = (typeof(*(ptr)))_val; \
> + x = (__force typeof(*(ptr)))_val; \
> _err; \
> })
>
> --
> MST
>
Acked-by: Steven Miao <realmz6@gmail.com>