From: Joe Perches <joe@perches.com>
To: Andrew Milkovich <amilkovich@gmail.com>
Cc: benjamin.romer@unisys.com, david.kershner@unisys.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed some coding style issues
Date: Wed, 17 Dec 2014 15:38:25 -0800 [thread overview]
Message-ID: <1418859505.28384.3.camel@perches.com> (raw)
In-Reply-To: <1418858832-16043-1-git-send-email-amilkovich@gmail.com>
On Wed, 2014-12-17 at 15:27 -0800, Andrew Milkovich wrote:
> Fixed some coding style issues
This is not a very descriptive subject or commit log message.
Please describe what changes are being done.
> diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/staging/unisys/virtpci/virtpci.c
[]
> @@ -279,9 +279,9 @@ static int add_vbus(struct add_vbus_guestpart *addparams)
> POSTCODE_LINUX_2(VPCI_CREATE_FAILURE_PC, POSTCODE_SEVERITY_ERR);
> return 0;
> }
> - write_vbus_chp_info(vbus->platform_data /* chanptr */ ,
> + write_vbus_chp_info(vbus->platform_data /* chanptr */,
> &chipset_driver_info);
I think it better to just remove the comments like:
write_vbus_chp_info(vbus->platform_data, &chipset_driver_info);
> @@ -466,7 +466,7 @@ static int pause_vhba(struct pause_virt_guestpart *pauseparams)
> GET_SCSIADAPINFO_FROM_CHANPTR(pauseparams->chanptr);
>
> LOGINF("Pausing vhba wwnn:%x:%x\n", scsi.wwnn.wwnn1, scsi.wwnn.wwnn2);
> - i = virtpci_device_serverdown(NULL /*no parent bus */ , VIRTHBA_TYPE,
> + i = virtpci_device_serverdown(NULL /*no parent bus */, VIRTHBA_TYPE,
> &scsi.wwnn, NULL);
i = vittpci_device_serverdown(NULL, VIRTHBA_TYPE, &scsi.wwnn, NULL);
etc.
prev parent reply other threads:[~2014-12-17 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 23:27 [PATCH] Staging: unisys: virtpci: fixed some coding style issues Andrew Milkovich
2014-12-17 23:38 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418859505.28384.3.camel@perches.com \
--to=joe@perches.com \
--cc=amilkovich@gmail.com \
--cc=benjamin.romer@unisys.com \
--cc=david.kershner@unisys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox