From: Michael Ellerman <mpe@ellerman.id.au>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Michael Neuling <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org, Ian Munsie <imunsie@au1.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] misc: cxl: sysfs.c: Remove unused function
Date: Mon, 22 Dec 2014 14:55:54 +1100 [thread overview]
Message-ID: <1419220554.20221.4.camel@ellerman.id.au> (raw)
In-Reply-To: <CAFo99ga9TYf5hnwOcoRPKsTHhhknoz6_axzP7spe0mvd=YPMLw@mail.gmail.com>
On Sun, 2014-12-21 at 13:46 +0100, Rickard Strandqvist wrote:
> 2014-12-21 5:05 GMT+01:00 Michael Neuling <mikey@neuling.org>:
> >> Remove the function mmio_size_show() that is not used anywhere.
> >
> > Did you compile check this patch?
> >
> > drivers/misc/cxl/sysfs.c:291:74: error: ‘mmio_size_show’ undeclared here (not in a function)
> >
> > It's used here:
> > static struct device_attribute afu_attrs[] = {
> > __ATTR_RO(mmio_size),
>
> Hi
>
> Sorry about that.
>
> Strange because I compile everything as allyesconfig, allmodconfig and
> allnoconfig.
The allyes should have picked it up, so you must have done something wrong.
Please be more careful with these attribute routines, they are not visible with
grep.
cheers
prev parent reply other threads:[~2014-12-22 3:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 16:13 [PATCH] misc: cxl: sysfs.c: Remove unused function Rickard Strandqvist
2014-12-21 4:05 ` Michael Neuling
2014-12-21 12:46 ` Rickard Strandqvist
2014-12-22 3:55 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419220554.20221.4.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox