From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754208AbaLVKOg (ORCPT ); Mon, 22 Dec 2014 05:14:36 -0500 Received: from cpsmtpb-ews08.kpnxchange.com ([213.75.39.13]:64968 "EHLO cpsmtpb-ews08.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754027AbaLVKOf (ORCPT ); Mon, 22 Dec 2014 05:14:35 -0500 Message-ID: <1419243273.30945.19.camel@x220> Subject: Re: [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL From: Paul Bolle To: Jiri Kosina Cc: Valentin Rothberg , Alistair Popple , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org Date: Mon, 22 Dec 2014 11:14:33 +0100 In-Reply-To: <1415008333.20372.26.camel@x220> References: <1415008333.20372.26.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 22 Dec 2014 10:14:33.0770 (UTC) FILETIME=[1512C8A0:01D01DD0] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On Mon, 2014-11-03 at 10:52 +0100, Paul Bolle wrote: > Commit 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") added a > select of IBM_EMAC_RGMII_WOL. But that Kconfig symbol isn't (yet) part > of the tree. So this select has been a nop since that commit was > included in v3.16-rc1. > > The code to add this symbol is not included in next-20141103. So let's > remove this select. It can be readded when that symbol is actually added > to the tree. > > Signed-off-by: Paul Bolle > Cc: Alistair Popple > --- > Untested. Done on top of next-20141103. > > Third time's a charm? First raised in > https://lkml.org/lkml/2014/5/1/106 . Reminder sent in > https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this > front, so this trivial patch seems reasonable now. > > A patch to readd this select could be added - if people still care about > it, that is - in the series that adds this symbol. A web search suggests > Alistair takes care of that series, so Alistair gets a Cc: here. This select of IBM_EMAC_RGMII_WOL still shows up in next-20141221 and v3.19-rc1. Did you have a chance to look at this patch? > arch/powerpc/platforms/44x/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig > index d2ac1c116454..5538e57c36c1 100644 > --- a/arch/powerpc/platforms/44x/Kconfig > +++ b/arch/powerpc/platforms/44x/Kconfig > @@ -214,7 +214,6 @@ config AKEBONO > select ETHERNET > select NET_VENDOR_IBM > select IBM_EMAC_EMAC4 > - select IBM_EMAC_RGMII_WOL > select USB if USB_SUPPORT > select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD Thanks, Paul Bolle