From: Joe Perches <joe@perches.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive
Date: Tue, 23 Dec 2014 05:14:26 -0800 [thread overview]
Message-ID: <1419340466.18020.7.camel@perches.com> (raw)
In-Reply-To: <1419339763-24901-1-git-send-email-pbonzini@redhat.com>
On Tue, 2014-12-23 at 14:02 +0100, Paolo Bonzini wrote:
> KERN_<LEVEL> is never redundant with printk_ratelimited.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4545,7 +4545,7 @@ sub process {
> }
>
> # check for logging functions with KERN_<LEVEL>
> - if ($line !~ /printk\s*\(/ &&
> + if ($line !~ /printk(?:_ratelimited)?\s*\(/ &&
Seems sensible bu this should probably add _once too
if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
Please add and resubmit cc'ing Andrew Morton too.
prev parent reply other threads:[~2014-12-23 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 13:02 [PATCH] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive Paolo Bonzini
2014-12-23 13:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419340466.18020.7.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox