From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756055AbaLWNOb (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Dec 2014 08:14:31 -0500
Received: from smtprelay0043.hostedemail.com ([216.40.44.43]:44478 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1755566AbaLWNOa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Dec 2014 08:14:30 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:960:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3868:3871:4321:5007:6261:10004:10400:10848:11232:11658:11914:12043:12114:12296:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: glue07_44283bd19614b
X-Filterd-Recvd-Size: 1372
Message-ID: <1419340466.18020.7.camel@perches.com>
Subject: Re: [PATCH] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive
From: Joe Perches <joe@perches.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Date: Tue, 23 Dec 2014 05:14:26 -0800
In-Reply-To: <1419339763-24901-1-git-send-email-pbonzini@redhat.com>
References: <1419339763-24901-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2014-12-23 at 14:02 +0100, Paolo Bonzini wrote:
> KERN_<LEVEL> is never redundant with printk_ratelimited.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4545,7 +4545,7 @@ sub process {
>  		}
>  
>  # check for logging functions with KERN_<LEVEL>
> -		if ($line !~ /printk\s*\(/ &&
> +		if ($line !~ /printk(?:_ratelimited)?\s*\(/ &&

Seems sensible bu this should probably add _once too

		if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&

Please add and resubmit cc'ing Andrew Morton too.