From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, linux-arch@vger.kernel.org
Subject: [PATCH repost 00/16] uaccess: fix sparse warning on get_user for bitwise types
Date: Thu, 25 Dec 2014 11:28:31 +0200 [thread overview]
Message-ID: <1419499661-8566-1-git-send-email-mst@redhat.com> (raw)
At Arnd's request, reposting now that 3.19-rc1 is out.
No changes from the original post, except that xtensa
and powerpc patches have been merged by maintainers.
Please review, and consider for 3.20.
At the moment, if p and x are both tagged as bitwise types,
get_user(x, p) produces a sparse warning on many architectures.
This is because *p on these architectures is loaded into long
(typically using asm), then cast back to typeof(*p).
When typeof(*p) is a bitwise type (which is uncommon), such a cast needs
__force, otherwise sparse produces a warning.
Some architectures already have the __force tag, add it
where it's missing.
Specificlly, vhost wants to read bitwise types from userspace using get_user.
At the moment this triggers sparse errors, since the value is passed through an
integer.
I tested this on x86 only. Since it's just adding __force, should be
trivially safe everywhere?
Michael S. Tsirkin (16):
x86/uaccess: fix sparse errors
alpha/uaccess: fix sparse errors
arm64/uaccess: fix sparse errors
avr32/uaccess: fix sparse errors
blackfin/uaccess: fix sparse errors
cris/uaccess: fix sparse errors
ia64/uaccess: fix sparse errors
m32r/uaccess: fix sparse errors
metag/uaccess: fix sparse errors
microblaze/uaccess: fix sparse errors
openrisc/uaccess: fix sparse errors
parisc/uaccess: fix sparse errors
sh/uaccess: fix sparse errors
sparc/uaccess: fix sparse errors
sparc/uaccess: fix sparse errors
m68k/uaccess: fix sparse errors
arch/alpha/include/asm/uaccess.h | 4 ++--
arch/arm64/include/asm/uaccess.h | 2 +-
arch/avr32/include/asm/uaccess.h | 4 ++--
arch/blackfin/include/asm/uaccess.h | 2 +-
arch/cris/include/asm/uaccess.h | 4 ++--
arch/ia64/include/asm/uaccess.h | 2 +-
arch/m32r/include/asm/uaccess.h | 4 ++--
arch/m68k/include/asm/uaccess_mm.h | 4 ++--
arch/metag/include/asm/uaccess.h | 4 ++--
arch/microblaze/include/asm/uaccess.h | 4 ++--
arch/openrisc/include/asm/uaccess.h | 4 ++--
arch/parisc/include/asm/uaccess.h | 2 +-
arch/sh/include/asm/uaccess.h | 4 ++--
arch/sparc/include/asm/uaccess_32.h | 8 ++++----
arch/sparc/include/asm/uaccess_64.h | 4 ++--
arch/x86/include/asm/uaccess.h | 2 +-
16 files changed, 29 insertions(+), 29 deletions(-)
--
MST
next reply other threads:[~2014-12-25 9:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 9:28 Michael S. Tsirkin [this message]
2014-12-25 9:28 ` [PATCH repost 01/16] x86/uaccess: fix sparse errors Michael S. Tsirkin
2014-12-25 9:28 ` [PATCH repost 02/16] alpha/uaccess: " Michael S. Tsirkin
2014-12-25 9:28 ` [PATCH repost 03/16] arm64/uaccess: " Michael S. Tsirkin
2015-01-23 15:33 ` Catalin Marinas
2015-01-23 15:42 ` Will Deacon
2015-01-23 16:35 ` Catalin Marinas
2014-12-25 9:28 ` [PATCH repost 04/16] avr32/uaccess: " Michael S. Tsirkin
2014-12-25 9:28 ` [PATCH repost 05/16] blackfin/uaccess: " Michael S. Tsirkin
2014-12-25 9:28 ` [PATCH repost 06/16] cris/uaccess: " Michael S. Tsirkin
2014-12-25 9:28 ` [PATCH repost 07/16] ia64/uaccess: " Michael S. Tsirkin
2014-12-25 9:28 ` [PATCH repost 08/16] m32r/uaccess: " Michael S. Tsirkin
2014-12-25 9:29 ` [PATCH repost 09/16] metag/uaccess: " Michael S. Tsirkin
2015-01-02 15:41 ` James Hogan
2015-01-04 10:52 ` Michael S. Tsirkin
2015-01-05 9:44 ` James Hogan
2015-01-05 13:00 ` Michael S. Tsirkin
2015-01-05 14:47 ` James Hogan
2015-01-06 10:00 ` Michael S. Tsirkin
2014-12-25 9:29 ` [PATCH repost 10/16] microblaze/uaccess: " Michael S. Tsirkin
2014-12-25 9:29 ` [PATCH repost 11/16] openrisc/uaccess: " Michael S. Tsirkin
2014-12-25 9:29 ` [PATCH repost 12/16] parisc/uaccess: " Michael S. Tsirkin
2014-12-25 22:37 ` Helge Deller
2014-12-27 16:14 ` Michael S. Tsirkin
2014-12-31 17:17 ` James Bottomley
2014-12-31 18:38 ` Michael S. Tsirkin
2014-12-31 20:23 ` James Bottomley
2014-12-25 9:29 ` [PATCH repost 13/16] sh/uaccess: " Michael S. Tsirkin
2014-12-25 9:29 ` [PATCH repost 14/16] sparc/uaccess: " Michael S. Tsirkin
2014-12-25 9:30 ` [PATCH repost 15/16] " Michael S. Tsirkin
2014-12-25 23:39 ` David Miller
2014-12-28 10:21 ` Michael S. Tsirkin
2014-12-25 9:30 ` [PATCH repost 16/16] m68k/uaccess: " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419499661-8566-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).