From: Wang Nan <wangnan0@huawei.com>
To: <namhyung@kernel.org>, <mingo@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <lizefan@huawei.com>
Subject: [PATCH] perf: fix building error in x86_64 when dwarf unwind is on
Date: Sat, 27 Dec 2014 09:26:11 +0800 [thread overview]
Message-ID: <1419643571-62764-1-git-send-email-wangnan0@huawei.com> (raw)
When build with 'make ARCH=x86' and dwarf unwind is on, there is a
compiling error:
CC /home/wn/perf/arch/x86/util/unwind-libdw.o
CC /home/wn/perf/arch/x86/tests/regs_load.o
arch/x86/tests/regs_load.S: Assembler messages:
arch/x86/tests/regs_load.S:65: Error: operand type mismatch for `push'
arch/x86/tests/regs_load.S:72: Error: operand type mismatch for `pop'
make[1]: *** [/home/wn/perf/arch/x86/tests/regs_load.o] Error 1
make[1]: INTERNAL: Exiting with 25 jobserver tokens available; should be 24!
make: *** [all] Error 2
...
Which is caused by incorrectly undefine macro HAVE_ARCH_X86_64_SUPPORT.
'config/Makefile.arch' tests __x86_64__ only when 'ARCH=x86_64'. However,
with 'ARCH=x86', the underlying compile may also be x86_64, which causes
mismatching.
This patch fixes it by checking __x86_64__ in both case of
'ARCH=x86_64' and 'ARCH=x86'.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
---
tools/perf/config/Makefile.arch | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/config/Makefile.arch b/tools/perf/config/Makefile.arch
index 851cd01..303a096 100644
--- a/tools/perf/config/Makefile.arch
+++ b/tools/perf/config/Makefile.arch
@@ -15,6 +15,8 @@ endif
ifeq ($(ARCH),x86_64)
override ARCH := x86
+endif
+ifeq ($(ARCH),x86)
IS_X86_64 := 0
ifeq (, $(findstring m32,$(CFLAGS)))
IS_X86_64 := $(shell echo __x86_64__ | ${CC} -E -x c - | tail -n 1)
--
1.8.4
next reply other threads:[~2014-12-27 1:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 1:26 Wang Nan [this message]
2014-12-29 7:56 ` [PATCH] perf: fix building error in x86_64 when dwarf unwind is on Namhyung Kim
2014-12-29 8:14 ` Wang Nan
2015-01-07 2:53 ` Wang Nan
2015-01-07 5:40 ` Namhyung Kim
2015-01-07 8:39 ` Jiri Olsa
2015-01-07 12:28 ` Wang Nan
2015-01-07 13:50 ` Namhyung Kim
2015-01-08 1:30 ` Wang Nan
2015-01-08 5:09 ` Namhyung Kim
2015-01-09 14:43 ` Jiri Olsa
2015-01-12 2:20 ` Wang Nan
2015-01-12 3:28 ` Namhyung Kim
2015-01-12 10:36 ` Jiri Olsa
2015-01-17 10:10 ` [tip:perf/urgent] perf tools: Fix " tip-bot for Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2015-02-03 19:58 [PATCH] perf: fix " Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419643571-62764-1-git-send-email-wangnan0@huawei.com \
--to=wangnan0@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).