From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: overlayfs: Fix coding style issues, missing a blank line after declarations
Date: Sun, 28 Dec 2014 19:01:00 -0800 [thread overview]
Message-ID: <1419822060.18886.1.camel@perches.com> (raw)
In-Reply-To: <20141229024951.GA9934@ZenIV.linux.org.uk>
On Mon, 2014-12-29 at 02:49 +0000, Al Viro wrote:
> On Mon, Dec 29, 2014 at 02:39:39AM +0000, Al Viro wrote:
> > On Sun, Dec 28, 2014 at 11:56:53AM +0600, Alexander Kuleshov wrote:
> > > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> > > ---
> >
> > For the record: anything of that sort against fs/*.c will be flushed down
> > the toilet where such valuable contributions belong. Don't even bother.
>
> Joe, could you please explain what has driven you to include that into
> scripts/checkpatch.pl and open the countless sphincters? Aren't we
> getting enough pointless patches as it is?
I don't care for that style actually.
It was Andrew Morton that wanted it used globally.
I wanted it to be a --strict test and only for
net/ and drivers/net/ where David Miller prefers
that style.
https://lkml.org/lkml/2014/3/6/550
> Al, stongly tempted to try and sneak a patch to checkpatch.pl declaring the
> lack of /* See Figure 1 */ within the first 10 lines of a function an offense
> against the Gods Of Style. Then sit back and watch the resulting spew...
Cool. Awaiting your patch...
next prev parent reply other threads:[~2014-12-29 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 5:56 [PATCH] fs: overlayfs: Fix coding style issues, missing a blank line after declarations Alexander Kuleshov
2014-12-29 2:39 ` Al Viro
2014-12-29 2:49 ` Al Viro
2014-12-29 3:01 ` Joe Perches [this message]
2014-12-29 3:38 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419822060.18886.1.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox