From: Joe Perches <joe@perches.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: gregkh@linuxfoundation.org, anarey@gmail.com,
mcgrof@do-not-panic.com, tapaswenipathak@gmail.com,
rmfrfs@gmail.com, yejiayily@gmail.com, gdonald@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace
Date: Wed, 31 Dec 2014 13:20:06 -0800 [thread overview]
Message-ID: <1420060806.6066.1.camel@perches.com> (raw)
In-Reply-To: <1420060243-10685-2-git-send-email-lstoakes@gmail.com>
On Wed, 2014-12-31 at 21:10 +0000, Lorenzo Stoakes wrote:
> This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
> in r8192U_dm.c and additionally it removes inconsistent whitespace throughout.
[]
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
[]
> +static u32 edca_setting_DL[HT_IOT_PEER_MAX] = {
> + 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0xa44f, 0x5ea44f
> +};
> +static u32 edca_setting_UL[HT_IOT_PEER_MAX] = {
> + 0x5e4322, 0xa44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f
> +};
It'd be nicer to use the same form and indentation
for both entries.
Probably be nicer to use:
static u32 edca_setting_DL[HT_IOT_PEER_MAX] = {
0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f
};
static u32 edca_setting_UL[HT_IOT_PEER_MAX] = {
0x5e4322, 0x00a44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f
};
so that the entries align too.
Would it be better to use const?
next prev parent reply other threads:[~2014-12-31 21:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 21:10 [PATCH v2 1/4] staging: rtl8192u: fix comments Lorenzo Stoakes
2014-12-31 21:10 ` [PATCH v2 2/4] staging: rtl8192u: fix whitespace Lorenzo Stoakes
2014-12-31 21:20 ` Joe Perches [this message]
2014-12-31 21:28 ` Lorenzo Stoakes
2014-12-31 21:33 ` [PATCH v3 " Lorenzo Stoakes
2015-01-01 4:47 ` Sudip Mukherjee
2015-01-01 5:40 ` Joe Perches
2015-01-01 6:28 ` Sudip Mukherjee
2015-01-01 10:06 ` Lorenzo Stoakes
2014-12-31 21:10 ` [PATCH v2 3/4] staging: rtl8192u: remove redundant code Lorenzo Stoakes
2015-01-01 4:49 ` Sudip Mukherjee
2015-01-01 4:58 ` Sudip Mukherjee
2015-01-01 10:12 ` Lorenzo Stoakes
2014-12-31 21:10 ` [PATCH v2 4/4] staging: rtl8192u: Refactor heavy nesting Lorenzo Stoakes
2015-01-10 17:58 ` [PATCH v2 1/4] staging: rtl8192u: fix comments Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420060806.6066.1.camel@perches.com \
--to=joe@perches.com \
--cc=anarey@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mcgrof@do-not-panic.com \
--cc=rmfrfs@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=yejiayily@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox