public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] infiniband: Remove duplicated KERN_<LEVEL> from pr_<level> uses
@ 2015-01-05 12:14 Joe Perches
  2015-01-05 14:39 ` Steve Wise
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2015-01-05 12:14 UTC (permalink / raw)
  To: Roland Dreier; +Cc: Eli Cohen, Steve Wise, LKML

These KERN_<LEVEL> uses are unnecessary and cause
bad logging output so remove them.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/infiniband/hw/cxgb4/device.c | 4 ++--
 drivers/infiniband/hw/mlx4/main.c    | 3 +--
 drivers/infiniband/hw/mlx5/qp.c      | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
index eb5df4e..e9e4b2f 100644
--- a/drivers/infiniband/hw/cxgb4/device.c
+++ b/drivers/infiniband/hw/cxgb4/device.c
@@ -1368,7 +1368,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list)
 					  t4_sq_host_wq_pidx(&qp->wq),
 					  t4_sq_wq_size(&qp->wq));
 		if (ret) {
-			pr_err(KERN_ERR MOD "%s: Fatal error - "
+			pr_err(MOD "%s: Fatal error - "
 			       "DB overflow recovery failed - "
 			       "error syncing SQ qid %u\n",
 			       pci_name(ctx->lldi.pdev), qp->wq.sq.qid);
@@ -1384,7 +1384,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list)
 					  t4_rq_wq_size(&qp->wq));
 
 		if (ret) {
-			pr_err(KERN_ERR MOD "%s: Fatal error - "
+			pr_err(MOD "%s: Fatal error - "
 			       "DB overflow recovery failed - "
 			       "error syncing RQ qid %u\n",
 			       pci_name(ctx->lldi.pdev), qp->wq.rq.qid);
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index 57ecc5b..6e15136 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -1493,8 +1493,7 @@ static void reset_gids_task(struct work_struct *work)
 			       MLX4_CMD_TIME_CLASS_B,
 			       MLX4_CMD_WRAPPED);
 		if (err)
-			pr_warn(KERN_WARNING
-				"set port %d command failed\n", gw->port);
+			pr_warn("set port %d command failed\n", gw->port);
 	}
 
 	mlx4_free_cmd_mailbox(dev, mailbox);
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index be0cd35..e5b4253 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -1394,7 +1394,7 @@ static int mlx5_set_path(struct mlx5_ib_dev *dev, const struct ib_ah_attr *ah,
 
 	if (ah->ah_flags & IB_AH_GRH) {
 		if (ah->grh.sgid_index >= gen->port[port - 1].gid_table_len) {
-			pr_err(KERN_ERR "sgid_index (%u) too large. max is %d\n",
+			pr_err("sgid_index (%u) too large. max is %d\n",
 			       ah->grh.sgid_index, gen->port[port - 1].gid_table_len);
 			return -EINVAL;
 		}



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH] infiniband: Remove duplicated KERN_<LEVEL> from pr_<level> uses
  2015-01-05 12:14 [PATCH] infiniband: Remove duplicated KERN_<LEVEL> from pr_<level> uses Joe Perches
@ 2015-01-05 14:39 ` Steve Wise
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Wise @ 2015-01-05 14:39 UTC (permalink / raw)
  To: 'Joe Perches', 'Roland Dreier'
  Cc: 'Eli Cohen', 'Steve Wise', 'LKML'

Acked-by: Steve Wise <swise@opengridcomputing.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-05 14:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-05 12:14 [PATCH] infiniband: Remove duplicated KERN_<LEVEL> from pr_<level> uses Joe Perches
2015-01-05 14:39 ` Steve Wise

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox