[PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

[PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

[nizamhaider786]

From: Nizam Haider <nizamhaider786@gmail.com>

fixed a coding style issue

Signed-off-by: Nizam Haider <nizamhaider786@gmail.com>
---
 drivers/spi/spi-gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
index aee4e75..702b0b8 100644
--- a/drivers/spi/spi-gpio.c
+++ b/drivers/spi/spi-gpio.c
@@ -92,7 +92,7 @@ struct spi_gpio {
 
 /*----------------------------------------------------------------------*/
 
-static inline struct spi_gpio * __pure
+static inline struct spi_gpio *__pure
 spi_to_spi_gpio(const struct spi_device *spi)
 {
 	const struct spi_bitbang	*bang;
@@ -103,7 +103,7 @@ spi_to_spi_gpio(const struct spi_device *spi)
 	return spi_gpio;
 }
 
-static inline struct spi_gpio_platform_data * __pure
+static inline struct spi_gpio_platform_data *__pure
 spi_to_pdata(const struct spi_device *spi)
 {
 	return &spi_to_spi_gpio(spi)->pdata;
-- 
2.1.3

Re: [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

[Joe Perches]

On Mon, 2015-01-05 at 17:31 +0530, nizamhaider786@gmail.com wrote:
> From: Nizam Haider <nizamhaider786@gmail.com>
> 
> fixed a coding style issue

This is a checkpatch defect and not a coding styple (style) issue.

Please don't blindly take checkpatch messages as dicta.

btw: The "From: " line in your email message body isn't necessary 
     or desired.  Please be careful with spelling/typos too.

> diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c
[]
> @@ -92,7 +92,7 @@ struct spi_gpio {
>  
>  /*----------------------------------------------------------------------*/
>  
> -static inline struct spi_gpio * __pure
> +static inline struct spi_gpio *__pure

Re: [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

On Mon, Jan 05, 2015 at 04:36:03AM -0800, Joe Perches wrote:
> On Mon, 2015-01-05 at 17:31 +0530, nizamhaider786@gmail.com wrote:
> > From: Nizam Haider <nizamhaider786@gmail.com>

> > fixed a coding style issue

> This is a checkpatch defect and not a coding styple (style) issue.

> Please don't blindly take checkpatch messages as dicta.

No, it's a coding style thing.  It may have been identified by
checkpatch but that's what it is.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

[Joe Perches]

On Mon, 2015-01-05 at 13:30 +0000, Mark Brown wrote:
> On Mon, Jan 05, 2015 at 04:36:03AM -0800, Joe Perches wrote:
> > On Mon, 2015-01-05 at 17:31 +0530, nizamhaider786@gmail.com wrote:
> > > From: Nizam Haider <nizamhaider786@gmail.com>
> 
> > > fixed a coding style issue
> 
> > This is a checkpatch defect and not a coding styple (style) issue.
> 
> > Please don't blindly take checkpatch messages as dicta.
> 
> No, it's a coding style thing.

It's a coding style consistency thing.

> It may have been identified by
> checkpatch but that's what it is.

__pure is a #define for a gcc attribute

include/linux/compiler-gcc.h:#define __pure                             __attribute__((pure))

macro attributes are almost always used
with space separators in the kernel.

All instances of __pure in the kernel have
a space before the use.

Re: [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On Mon, Jan 05, 2015 at 05:31:03PM +0530, nizamhaider786@gmail.com wrote:
> From: Nizam Haider <nizamhaider786@gmail.com>
> 
> fixed a coding style issue

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 3/3] spi:spi-gpio: fixed space coding styple issue

[Joe Perches]

On Mon, 2015-01-05 at 18:32 +0000, Mark Brown wrote:
> On Mon, Jan 05, 2015 at 05:31:03PM +0530, nizamhaider786@gmail.com wrote:
> > From: Nizam Haider <nizamhaider786@gmail.com>
> > 
> > fixed a coding style issue
> 
> Applied, thanks.

Still unnecessary and decidedly non-standard kernel style.