From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754133AbbAEOV6 (ORCPT ); Mon, 5 Jan 2015 09:21:58 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:62765 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754050AbbAEOVP (ORCPT ); Mon, 5 Jan 2015 09:21:15 -0500 From: Bartosz Golaszewski To: Guenter Roeck Cc: LKML , Benoit Cousson , Patrick Titiano , LM Sensors , Bartosz Golaszewski Subject: [PATCH v8 3/5] hwmon: ina2xx: don't accept shunt values greater than the calibration factor Date: Mon, 5 Jan 2015 15:20:54 +0100 Message-Id: <1420467656-6112-4-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1420467656-6112-1-git-send-email-bgolaszewski@baylibre.com> References: <1420467656-6112-1-git-send-email-bgolaszewski@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shunt resistance values greater than the chip's calibration factor make no sense since the actual value written to the register equals: / Bail-out from ina2xx_probe() if the configured value is greater than the calibration factor. Signed-off-by: Bartosz Golaszewski --- drivers/hwmon/ina2xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c index 39e017b..3234e57 100644 --- a/drivers/hwmon/ina2xx.c +++ b/drivers/hwmon/ina2xx.c @@ -313,7 +313,8 @@ static int ina2xx_probe(struct i2c_client *client, data->config = &ina2xx_config[data->kind]; data->client = client; - if (data->rshunt <= 0) + if (data->rshunt <= 0 || + data->rshunt > data->config->calibration_factor) return -ENODEV; ret = ina2xx_init(data); -- 2.1.3