From: Philipp Zabel <p.zabel@pengutronix.de>
To: Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Tomasz Figa <tomasz.figa@gmail.com>,
Vivek Gautam <gautam.vivek@samsung.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Pankaj Dubey <pankaj.dubey@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH] mfd: syscon: fix syscon probing from dt
Date: Tue, 6 Jan 2015 16:30:36 +0100 [thread overview]
Message-ID: <1420558236-14063-1-git-send-email-p.zabel@pengutronix.de> (raw)
Patch bdb0066df96e ("mfd: syscon: Decouple syscon interface from platform devices")
breaks probing pure syscon devices from device tree, such as anatop and
iomuxc-gpr on i.MX. This patch adds back the dt id table to match against
"syscon" compatible device tree nodes.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/mfd/syscon.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index 176bf0f..70b8654 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -174,6 +174,11 @@ struct regmap *syscon_regmap_lookup_by_phandle(struct device_node *np,
}
EXPORT_SYMBOL_GPL(syscon_regmap_lookup_by_phandle);
+static const struct of_device_id of_syscon_match[] = {
+ { .compatible = "syscon", },
+ { },
+};
+
static int syscon_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -219,6 +224,7 @@ static const struct platform_device_id syscon_ids[] = {
static struct platform_driver syscon_driver = {
.driver = {
.name = "syscon",
+ .of_match_table = of_syscon_match,
},
.probe = syscon_probe,
.id_table = syscon_ids,
--
2.1.4
next reply other threads:[~2015-01-06 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 15:30 Philipp Zabel [this message]
2015-01-06 19:05 ` [PATCH] mfd: syscon: fix syscon probing from dt Heiko Stübner
2015-01-07 9:58 ` Philipp Zabel
2015-01-06 19:36 ` Arnd Bergmann
2015-01-07 10:57 ` Philipp Zabel
2015-01-07 11:17 ` Pankaj Dubey
2015-01-07 11:55 ` Philipp Zabel
2015-01-08 11:07 ` Pankaj Dubey
2015-01-08 11:47 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420558236-14063-1-git-send-email-p.zabel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=arnd@arndb.de \
--cc=gautam.vivek@samsung.com \
--cc=heiko@sntech.de \
--cc=javier.martinez@collabora.co.uk \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=sameo@linux.intel.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).