From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756105AbbAFRUw (ORCPT ); Tue, 6 Jan 2015 12:20:52 -0500 Received: from smtprelay0041.hostedemail.com ([216.40.44.41]:58880 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756025AbbAFRUl (ORCPT ); Tue, 6 Jan 2015 12:20:41 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2693:2828:2903:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3874:4321:5007:6261:10004:10400:10848:11026:11232:11473:11658:11914:12517:12519:12740:13069:13149:13230:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bike09_7a0bf0b213e37 X-Filterd-Recvd-Size: 1599 Message-ID: <1420564837.2652.33.camel@perches.com> Subject: Re: [PATCH 1/3] pstore: use snprintf From: Joe Perches To: Mark Salyzyn Cc: linux-kernel@vger.kernel.org, Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck Date: Tue, 06 Jan 2015 09:20:37 -0800 In-Reply-To: <1420564526-24420-1-git-send-email-salyzyn@android.com> References: <1420564526-24420-1-git-send-email-salyzyn@android.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-01-06 at 09:15 -0800, Mark Salyzyn wrote: > No guarantees that the names will not exceed the > name buffer with future adjustments. [] > diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c [] > @@ -338,32 +338,34 @@ int pstore_mkfile(enum pstore_type_id type, char *psname, u64 id, int count, > > switch (type) { > case PSTORE_TYPE_DMESG: > - sprintf(name, "dmesg-%s-%lld%s", psname, id, > + snprintf(name, sizeof(name), "dmesg-%s-%lld%s", psname, id, > compressed ? ".enc.z" : ""); scnprintf to ensure null termination? (and maybe better written like) scnprintf(name, sizeof(name), "dmesg-%s-%lld%s", psname, id, compressed ? ".enc.z" : "");