From: Daniel Thompson <daniel.thompson@linaro.org>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
linux-kernel@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
patches@linaro.org, linaro-kernel@lists.linaro.org,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: [RESEND PATCH 3.19-rc2 3/3] kdb: Const qualifier for kdb_getstr's prompt argument
Date: Wed, 7 Jan 2015 16:10:14 +0000 [thread overview]
Message-ID: <1420647014-4897-4-git-send-email-daniel.thompson@linaro.org> (raw)
In-Reply-To: <1420647014-4897-1-git-send-email-daniel.thompson@linaro.org>
All current callers of kdb_getstr() can pass constant pointers via the
prompt argument. This patch adds a const qualification to make explicit
the fact that this is safe.
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
---
kernel/debug/kdb/kdb_io.c | 2 +-
kernel/debug/kdb/kdb_private.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 70e0f494d3f8..59a6071139bc 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -439,7 +439,7 @@ poll_again:
* substituted for %d, %x or %o in the prompt.
*/
-char *kdb_getstr(char *buffer, size_t bufsize, char *prompt)
+char *kdb_getstr(char *buffer, size_t bufsize, const char *prompt)
{
if (prompt && kdb_prompt_str != prompt)
strncpy(kdb_prompt_str, prompt, CMD_BUFLEN);
diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h
index 30ed4f3d8606..aa90a6a63e88 100644
--- a/kernel/debug/kdb/kdb_private.h
+++ b/kernel/debug/kdb/kdb_private.h
@@ -212,7 +212,7 @@ extern void kdb_ps1(const struct task_struct *p);
extern void kdb_print_nameval(const char *name, unsigned long val);
extern void kdb_send_sig_info(struct task_struct *p, struct siginfo *info);
extern void kdb_meminfo_proc_show(void);
-extern char *kdb_getstr(char *, size_t, char *);
+extern char *kdb_getstr(char *, size_t, const char *);
extern void kdb_gdb_state_pass(char *buf);
/* Defines for kdb_symbol_print */
--
1.9.3
prev parent reply other threads:[~2015-01-07 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 12:29 [PATCH 3.17-rc4 0/3] kdb: Improve command output searching Daniel Thompson
2014-09-11 12:29 ` [PATCH 3.17-rc4 1/3] kdb: Fix a prompt management bug when using | grep Daniel Thompson
2014-09-11 12:29 ` [PATCH 3.17-rc4 2/3] kdb: Provide forward search at more prompt Daniel Thompson
2014-09-11 12:29 ` [PATCH 3.17-rc4 3/3] kdb: Const qualifier for kdb_getstr's prompt argument Daniel Thompson
2014-11-06 16:02 ` [RESEND PATCH 3.18-rc3 0/3] kdb: Improve command output searching Daniel Thompson
2014-11-06 16:02 ` [RESEND PATCH 3.18-rc3 1/3] kdb: Fix a prompt management bug when using | grep Daniel Thompson
2014-11-06 16:02 ` [RESEND PATCH 3.18-rc3 2/3] kdb: Provide forward search at more prompt Daniel Thompson
2014-11-06 16:02 ` [RESEND PATCH 3.18-rc3 3/3] kdb: Const qualifier for kdb_getstr's prompt argument Daniel Thompson
2015-01-07 16:10 ` [RESEND PATCH 3.19-rc2 0/3] kdb: Improve command output searching Daniel Thompson
2015-01-07 16:10 ` [RESEND PATCH 3.19-rc2 1/3] kdb: Fix a prompt management bug when using | grep Daniel Thompson
2015-01-07 16:10 ` [RESEND PATCH 3.19-rc2 2/3] kdb: Provide forward search at more prompt Daniel Thompson
2015-01-07 16:10 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420647014-4897-4-git-send-email-daniel.thompson@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=jason.wessel@windriver.com \
--cc=john.stultz@linaro.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).