From: Giel van Schijndel <me@mortis.eu>
To: linux-kernel@vger.kernel.org
Cc: David Sterba <dsterba@suse.cz>, Giel van Schijndel <me@mortis.eu>,
Armin Schindler <mac@melware.de>,
Karsten Keil <isdn@linux-pingi.de>,
netdev@vger.kernel.org (open list:ISDN SUBSYSTEM)
Subject: [PATCH RESEND] isdn: fix NUL (\0 or \x00) specification in string
Date: Wed, 7 Jan 2015 20:10:12 +0100 [thread overview]
Message-ID: <1420657812-19445-1-git-send-email-me@mortis.eu> (raw)
In-Reply-To: <1420394722-20197-1-git-send-email-me@mortis.eu>
In C one can either use '\0' or '\x00' (or '\000') to add a NUL byte to
a string. '\0x00' isn't part of these and will in fact result in a
single NUL followed by "x00". This fixes that.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Reported-at: http://www.viva64.com/en/b/0299/
---
drivers/isdn/hardware/eicon/message.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/hardware/eicon/message.c b/drivers/isdn/hardware/eicon/message.c
index a82e542..0b38060 100644
--- a/drivers/isdn/hardware/eicon/message.c
+++ b/drivers/isdn/hardware/eicon/message.c
@@ -4880,7 +4880,7 @@ static void sig_ind(PLCI *plci)
byte SS_Ind[] = "\x05\x02\x00\x02\x00\x00"; /* Hold_Ind struct*/
byte CF_Ind[] = "\x09\x02\x00\x06\x00\x00\x00\x00\x00\x00";
byte Interr_Err_Ind[] = "\x0a\x02\x00\x07\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00";
- byte CONF_Ind[] = "\x09\x16\x00\x06\x00\x00\0x00\0x00\0x00\0x00";
+ byte CONF_Ind[] = "\x09\x16\x00\x06\x00\x00\x00\x00\x00\x00";
byte force_mt_info = false;
byte dir;
dword d;
--
2.1.4
next prev parent reply other threads:[~2015-01-07 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 18:05 [PATCH] Fix NUL (\0 or \x00) specification in string Giel van Schijndel
2015-01-04 23:04 ` Giel van Schijndel
2015-01-05 15:00 ` David Sterba
2015-01-06 19:28 ` Giel van Schijndel
2015-01-07 12:22 ` David Sterba
2015-01-07 18:45 ` Andy Shevchenko
2015-01-07 19:10 ` Giel van Schijndel [this message]
2015-01-12 20:32 ` [PATCH RESEND] isdn: fix " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420657812-19445-1-git-send-email-me@mortis.eu \
--to=me@mortis.eu \
--cc=dsterba@suse.cz \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).