From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932287AbbAIJrx (ORCPT ); Fri, 9 Jan 2015 04:47:53 -0500 Received: from smarthost01c.mail.zen.net.uk ([212.23.1.5]:43062 "EHLO smarthost01c.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752539AbbAIJrv (ORCPT ); Fri, 9 Jan 2015 04:47:51 -0500 Message-ID: <1420796864.4160.6.camel@linaro.org> Subject: Re: [PATCH v20 01/11] ARM: probes: move all probe code to dedicate directory From: "Jon Medhurst (Tixy)" To: Wang Nan Cc: masami.hiramatsu.pt@hitachi.com, linux@arm.linux.org.uk, lizefan@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Fri, 09 Jan 2015 09:47:44 +0000 In-Reply-To: <1420769989-29208-1-git-send-email-wangnan0@huawei.com> References: <1420457350-77053-1-git-send-email-wangnan0@huawei.com> <1420769989-29208-1-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-smarthost01c-IP: [82.69.122.217] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-01-09 at 10:19 +0800, Wang Nan wrote: > In discussion on LKML (https://lkml.org/lkml/2014/11/28/158), Russell > King suggests to move all probe related code to arch/arm/probes. This > patch does the work. Due to dependency on 'arch/arm/kernel/patch.h', this > patch also moves patch.h to 'arch/arm/include/asm/patch.h', and related > '#include' directives are also midified to '#include '. > > Following is an overview of this patch: > > ./arch/arm/kernel/ ./arch/arm/probes/ > |-- Makefile |-- Makefile > |-- probes-arm.c ==> |-- decode-arm.c > |-- probes-arm.h ==> |-- decode-arm.h > |-- probes-thumb.c ==> |-- decode-thumb.c > |-- probes-thumb.h ==> |-- decode-thumb.h > |-- probes.c ==> |-- decode.c > |-- probes.h ==> |-- decode.h > | |-- kprobes > | | |-- Makefile > |-- kprobes-arm.c ==> | |-- actions-arm.c > |-- kprobes-common.c ==> | |-- actions-common.c > |-- kprobes-thumb.c ==> | |-- actions-thumb.c > |-- kprobes.c ==> | |-- core.c > |-- kprobes.h ==> | |-- core.h > |-- kprobes-test-arm.c ==> | |-- test-arm.c > |-- kprobes-test.c ==> | |-- test-core.c > |-- kprobes-test.h ==> | |-- test-core.h > |-- kprobes-test-thumb.c ==> | `-- test-thumb.c > | `-- uprobes > | |-- Makefile > |-- uprobes-arm.c ==> |-- actions-arm.c > |-- uprobes.c ==> |-- core.c > |-- uprobes.h ==> `-- core.h > | > `-- patch.h ==> arch/arm/include/asm/patch.h > > Signed-off-by: Wang Nan > Acked-by: Masami Hiramatsu > --- Might have been good to mention what's changed in this version, I worked out its kgdb.c, comments below... [...] > diff --git a/arch/arm/kernel/kgdb.c b/arch/arm/kernel/kgdb.c > index 07db2f8..f3eb83f 100644 > --- a/arch/arm/kernel/kgdb.c > +++ b/arch/arm/kernel/kgdb.c > @@ -16,7 +16,7 @@ > > #include > > -#include "patch.h" > +#include To keep alphabetical ordering of headers this should be above the #include Don't bother resending the patch, I'll just update the patch in the git branch I'm putting together. -- Tixy