[PATCH v7] Staging: comedi: patch to fix line over 80 characters warning

[PATCH v7] Staging: comedi: patch to fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to pcl812.c that fix line over 80 characters warning
which is found by checkpatch.pl tool. Reduce the extra space around
equal sign that fix warning.

Signed-off-by: Jitendra kumar khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..9b576bc 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -1235,7 +1235,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		for (i = 0; i < 2; i++) {
 			unsigned long dmabuf;
 
-			dmabuf =  __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
+			dmabuf = __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
 			if (!dmabuf)
 				return -ENOMEM;
 
-- 
1.9.1

Re: [PATCH v7] Staging: comedi: patch to fix line over 80 characters warning

[Greg KH]

On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote:
> This is patch to pcl812.c that fix line over 80 characters warning
> which is found by checkpatch.pl tool. Reduce the extra space around
> equal sign that fix warning.
> 
> Signed-off-by: Jitendra kumar khasdev <jkhasdev@gmail.com>
> ---
>  drivers/staging/comedi/drivers/pcl812.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree :(

Re: [PATCH v7] Staging: comedi: patch to fix line over 80 characters warning

[jitendra kumar khasdev]

Will you give reason for not apply my patch on your tree. I have
tested by appling on linux main tree.


On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote:
> This is patch to pcl812.c that fix line over 80 characters warning
> which is found by checkpatch.pl tool. Reduce the extra space around
> equal sign that fix warning.

Regards,
JItendra kumar khasdev,
jitendra-02.github.io | Mo. 8871242083


On 1/18/15, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote:
>> This is patch to pcl812.c that fix line over 80 characters warning
>> which is found by checkpatch.pl tool. Reduce the extra space around
>> equal sign that fix warning.
>>
>> Signed-off-by: Jitendra kumar khasdev <jkhasdev@gmail.com>
>> ---
>>  drivers/staging/comedi/drivers/pcl812.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Does not apply to my tree :(
>

Re: [PATCH v7] Staging: comedi: patch to fix line over 80 characters warning

[Greg KH]

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sun, Jan 18, 2015 at 07:47:50PM +0530, jitendra kumar khasdev wrote:
> Will you give reason for not apply my patch on your tree. I have
> tested by appling on linux main tree.

Probably because someone else sent in fixes that changed things in this
area, and those patches are not in Linus's tree yet.  Please always work
against the linux-next tree, or even better, my staging.git tree, using
the staging-testing branch.

thanks,

greg k-h