public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch/x86/kernel/cpu/common.c: split log entry into logical components
@ 2015-01-10 22:21 Scot Doyle
  2015-01-10 22:35 ` Joe Perches
  0 siblings, 1 reply; 4+ messages in thread
From: Scot Doyle @ 2015-01-10 22:21 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86; +Cc: linux-kernel

Call printk twice since this log entry has two lines and headings.

[    0.009285] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024
Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 1024, 1GB 4

Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
---
 arch/x86/kernel/cpu/common.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index c604965..76f253f 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -496,12 +496,12 @@ void cpu_detect_tlb(struct cpuinfo_x86 *c)
 	if (this_cpu->c_detect_tlb)
 		this_cpu->c_detect_tlb(c);
 
-	printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n"
-		"Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d, 1GB %d\n",
+	printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n",
 		tlb_lli_4k[ENTRIES], tlb_lli_2m[ENTRIES],
-		tlb_lli_4m[ENTRIES], tlb_lld_4k[ENTRIES],
-		tlb_lld_2m[ENTRIES], tlb_lld_4m[ENTRIES],
-		tlb_lld_1g[ENTRIES]);
+		tlb_lli_4m[ENTRIES]);
+	printk(KERN_INFO "Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d, 1GB %d\n",
+		tlb_lld_4k[ENTRIES], tlb_lld_2m[ENTRIES],
+		tlb_lld_4m[ENTRIES], tlb_lld_1g[ENTRIES]);
 }
 
 void detect_ht(struct cpuinfo_x86 *c)
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arch/x86/kernel/cpu/common.c: split log entry into logical components
  2015-01-10 22:21 [PATCH] arch/x86/kernel/cpu/common.c: split log entry into logical components Scot Doyle
@ 2015-01-10 22:35 ` Joe Perches
  2015-01-10 23:57   ` Scot Doyle
  0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2015-01-10 22:35 UTC (permalink / raw)
  To: Scot Doyle
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-kernel

On Sat, 2015-01-10 at 22:21 +0000, Scot Doyle wrote:
> Call printk twice since this log entry has two lines and headings.
> 
> [    0.009285] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024
> Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 1024, 1GB 4
> 
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> ---
>  arch/x86/kernel/cpu/common.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index c604965..76f253f 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -496,12 +496,12 @@ void cpu_detect_tlb(struct cpuinfo_x86 *c)
>  	if (this_cpu->c_detect_tlb)
>  		this_cpu->c_detect_tlb(c);
>  
> -	printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n"
> -		"Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d, 1GB %d\n",
> +	printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n",
>  		tlb_lli_4k[ENTRIES], tlb_lli_2m[ENTRIES],
> -		tlb_lli_4m[ENTRIES], tlb_lld_4k[ENTRIES],
> -		tlb_lld_2m[ENTRIES], tlb_lld_4m[ENTRIES],
> -		tlb_lld_1g[ENTRIES]);
> +		tlb_lli_4m[ENTRIES]);
> +	printk(KERN_INFO "Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d, 1GB %d\n",
> +		tlb_lld_4k[ENTRIES], tlb_lld_2m[ENTRIES],
> +		tlb_lld_4m[ENTRIES], tlb_lld_1g[ENTRIES]);
>  }

Check your dmesg version

https://lkml.org/lkml/2014/11/1/67
https://lkml.org/lkml/2014/11/2/1





^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arch/x86/kernel/cpu/common.c: split log entry into logical components
  2015-01-10 22:35 ` Joe Perches
@ 2015-01-10 23:57   ` Scot Doyle
  2015-01-11  0:07     ` Borislav Petkov
  0 siblings, 1 reply; 4+ messages in thread
From: Scot Doyle @ 2015-01-10 23:57 UTC (permalink / raw)
  To: Joe Perches, Steven Honeyman
  Cc: Borislav Petkov, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	x86, linux-kernel

On Sat, 10 Jan 2015, Joe Perches wrote:

> On Sat, 2015-01-10 at 22:21 +0000, Scot Doyle wrote:
> > Call printk twice since this log entry has two lines and headings.
> > 
> > [    0.009285] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024
> > Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 1024, 1GB 4
> > 
> > Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> > ---
> >  arch/x86/kernel/cpu/common.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> > index c604965..76f253f 100644
> > --- a/arch/x86/kernel/cpu/common.c
> > +++ b/arch/x86/kernel/cpu/common.c
> > @@ -496,12 +496,12 @@ void cpu_detect_tlb(struct cpuinfo_x86 *c)
> >  	if (this_cpu->c_detect_tlb)
> >  		this_cpu->c_detect_tlb(c);
> >  
> > -	printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n"
> > -		"Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d, 1GB %d\n",
> > +	printk(KERN_INFO "Last level iTLB entries: 4KB %d, 2MB %d, 4MB %d\n",
> >  		tlb_lli_4k[ENTRIES], tlb_lli_2m[ENTRIES],
> > -		tlb_lli_4m[ENTRIES], tlb_lld_4k[ENTRIES],
> > -		tlb_lld_2m[ENTRIES], tlb_lld_4m[ENTRIES],
> > -		tlb_lld_1g[ENTRIES]);
> > +		tlb_lli_4m[ENTRIES]);
> > +	printk(KERN_INFO "Last level dTLB entries: 4KB %d, 2MB %d, 4MB %d, 1GB %d\n",
> > +		tlb_lld_4k[ENTRIES], tlb_lld_2m[ENTRIES],
> > +		tlb_lld_4m[ENTRIES], tlb_lld_1g[ENTRIES]);
> >  }
> 
> Check your dmesg version
> 
> https://lkml.org/lkml/2014/11/1/67
> https://lkml.org/lkml/2014/11/2/1
> 

Thanks Joe.

Steven, are you planning to resubmit the patch as suggested by Borislav?

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arch/x86/kernel/cpu/common.c: split log entry into logical components
  2015-01-10 23:57   ` Scot Doyle
@ 2015-01-11  0:07     ` Borislav Petkov
  0 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2015-01-11  0:07 UTC (permalink / raw)
  To: Scot Doyle
  Cc: Joe Perches, Steven Honeyman, Thomas Gleixner, Ingo Molnar,
	H. Peter Anvin, x86, linux-kernel

On Sat, Jan 10, 2015 at 11:57:04PM +0000, Scot Doyle wrote:
> Steven, are you planning to resubmit the patch as suggested by Borislav?

I think he did resubmit:

https://lkml.kernel.org/r/1415227938-16927-1-git-send-email-stevenhoneyman@gmail.com

but it seems it has been forgotten. I'll pick it up.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-11  0:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-10 22:21 [PATCH] arch/x86/kernel/cpu/common.c: split log entry into logical components Scot Doyle
2015-01-10 22:35 ` Joe Perches
2015-01-10 23:57   ` Scot Doyle
2015-01-11  0:07     ` Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox