From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Benjamin Romer <benjamin.romer@unisys.com>,
David Kershner <david.kershner@unisys.com>,
devel@driverdev.osuosl.org, sparmaintainer@unisys.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err
Date: Sat, 10 Jan 2015 20:55:21 -0800 [thread overview]
Message-ID: <1420952121.32288.1.camel@perches.com> (raw)
In-Reply-To: <20150111041319.GB22334@kroah.com>
On Sat, 2015-01-10 at 20:13 -0800, Greg Kroah-Hartman wrote:
> On Sat, Jan 10, 2015 at 07:09:02PM -0800, Joe Perches wrote:
> > Use the normal logging facility instead of a new macro.
> >
> > Miscellanea:
> >
> > o Realign arguments
> > o Remove unnecessary alloc error messages as alloc failures
> > already emits a generic OOM message with a dump_stack
> > o Add missing newlines to these messages to avoid interleaving
> > o Spelling/typo fixes in those messages
[]
> I rejected the other patch that did much this same thing, almost all of
> these should be converted to use dev_* calls instead of pr_* calls, as
> this is a driver, and drivers should always have access to a struct
> device. If not, they need to be fixed.
Baby steps.
This one prevents interleaving
and fixes typos.
next prev parent reply other threads:[~2015-01-11 4:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 3:09 [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err Joe Perches
2015-01-11 4:13 ` Greg Kroah-Hartman
2015-01-11 4:55 ` Joe Perches [this message]
2015-01-11 5:24 ` Greg Kroah-Hartman
2015-01-11 5:32 ` Joe Perches
2015-01-11 5:51 ` Greg Kroah-Hartman
2015-01-11 16:57 ` Greg Kroah-Hartman
2015-01-11 17:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420952121.32288.1.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.romer@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox