From: Joe Perches <joe@perches.com>
To: Bilel DRIRA <bilel.dr@gmail.com>
Cc: marek.belisko@gmail.com, gregkh@linuxfoundation.org,
tapaswenipathak@gmail.com, gdonald@gmail.com,
aybuke.147@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix else style error
Date: Tue, 13 Jan 2015 08:01:39 -0800 [thread overview]
Message-ID: <1421164899.9233.21.camel@perches.com> (raw)
In-Reply-To: <1421150221-16028-1-git-send-email-bilel.dr@gmail.com>
On Tue, 2015-01-13 at 12:57 +0100, Bilel DRIRA wrote:
> ERROR: else should follow close brace '}'
[]
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
[]
> @@ -572,8 +572,7 @@ static void ft1000_hbchk(u_long data)
> if (tempword != ho) {
> if (info->AsicID == ELECTRABUZZ_ID) {
> tempword = ft1000_read_dpram(dev, FT1000_HI_HO);
> - }
> - else {
> + } else {
> tempword = ntohs(ft1000_read_dpram_mag_16(dev, FT1000_MAG_HI_HO, FT1000_MAG_HI_HO_INDX));
> }
> }
True, but you could instead remove all the braces
around both arms from all uses of
if (test) {
<single statement>;
} else {
<single statement>;
}
> @@ -688,15 +687,13 @@ static void ft1000_hbchk(u_long data)
> if (tempword != hi) {
> if (info->AsicID == ELECTRABUZZ_ID) {
> ft1000_write_dpram(dev, FT1000_HI_HO, hi);
> - }
> - else {
> + } else {
> ft1000_write_dpram_mag_16(dev, FT1000_MAG_HI_HO, hi_mag, FT1000_MAG_HI_HO_INDX);
> }
etc...
next prev parent reply other threads:[~2015-01-13 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ft1000else_style>
2015-01-13 11:57 ` [PATCH] staging: ft1000: fix else style error Bilel DRIRA
2015-01-13 16:01 ` Joe Perches [this message]
2015-01-13 21:21 ` bill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421164899.9233.21.camel@perches.com \
--to=joe@perches.com \
--cc=aybuke.147@gmail.com \
--cc=bilel.dr@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox