From: Jason Wang <jasowang@redhat.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
KY Srinivasan <kys@microsoft.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: RE: [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer failure
Date: Wed, 14 Jan 2015 02:36:00 +0008 [thread overview]
Message-ID: <1421202480.4752.0@smtp.corp.redhat.com> (raw)
In-Reply-To: <F792CF86EFE20D4AB8064279AFBA51C61EA7CFF9@SIXPRD3002MB028.064d.mgd.msft.net >
On Wed, Jan 14, 2015 at 9:43 AM, Dexuan Cui <decui@microsoft.com> wrote:
>> -----Original Message-----
>> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
>> Sent: Tuesday, January 13, 2015 21:52 PM
>> To: Dexuan Cui; KY Srinivasan
>> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
>> driverdev-
>> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
>> jasowang@redhat.com; Haiyang Zhang
>> Subject: Re: [PATCH v3] hv: hv_fcopy: drop the obsolete message on
>> transfer
>> failure
>>
>> Dexuan Cui <decui@microsoft.com> writes:
>>
>> > In the case the user-space daemon crashes, hangs or is killed, we
>> > need to down the semaphore, otherwise, after the daemon starts
>> next
>> > time, the obsolete data in fcopy_transaction.message or
>> > fcopy_transaction.fcopy_msg will be used immediately.
>>
>> It seems this patch got lost and I don't see it in recent 'resend'
>> series. K.Y., Dexuan, can you please take a look?
> Hi Vitaly, Jason,
> The patch can't fix all the corner cases (it would need non-trivial
> efforts for that)
> as we discussed, but I think it would be better for us to have it as
> it can indeed fix
> an obvious issue and doesn't introduce new issues.
>
> I think I can document the known discussed corner cases in the patch
> as TODOs
> and resend the patch.
>
> Please let me know if you have different opinions. :-)
>
> Thanks,
> -- Dexuan
Yes, I think it's ok.
We can do other fixes on top.
Thanks
next prev parent reply other threads:[~2015-01-14 2:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 13:09 [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer failure Dexuan Cui
2014-11-28 6:47 ` Jason Wang
2014-11-28 8:36 ` Dexuan Cui
[not found] ` <F792CF86EFE20D4AB8064279AFBA51C613E66566@HKNPRD3002MB017.064d.mgd.msft.net >
2014-11-28 10:12 ` Jason Wang
2014-11-28 11:54 ` Dexuan Cui
[not found] ` <F792CF86EFE20D4AB8064279AFBA51C613E66AAA@HKNPRD3002MB017.064d.mgd.msft.net >
2014-12-01 8:22 ` Jason Wang
2014-12-01 9:47 ` Dexuan Cui
2014-12-01 9:55 ` Vitaly Kuznetsov
[not found] ` <F792CF86EFE20D4AB8064279AFBA51C613E691B8@HKNPRD3002MB017.064d.mgd.msft.net >
2014-12-01 10:18 ` Jason Wang
2014-12-01 11:00 ` Dexuan Cui
2014-12-01 15:54 ` KY Srinivasan
2014-12-02 5:33 ` Dexuan Cui
[not found] ` <F792CF86EFE20D4AB8064279AFBA51C613E6B93B@HKNPRD3002MB017.064d.mgd.msft.net >
2014-12-02 6:58 ` Jason Wang
2015-01-13 13:52 ` Vitaly Kuznetsov
2015-01-14 1:43 ` Dexuan Cui
[not found] ` <F792CF86EFE20D4AB8064279AFBA51C61EA7CFF9@SIXPRD3002MB028.064d.mgd.msft.net >
2015-01-14 2:28 ` Jason Wang [this message]
2015-01-14 3:21 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421202480.4752.0@smtp.corp.redhat.com \
--to=jasowang@redhat.com \
--cc=apw@canonical.com \
--cc=decui@microsoft.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox