Re: [tpmdd-devel] Question about duplicate definitions of transmit_cmd in tpm-sysfs.c and tmp-interface.c

Re: [tpmdd-devel] Question about duplicate definitions of transmit_cmd in tpm-sysfs.c and tmp-interface.c

[Jason Gunthorpe]

On Sat, Dec 27, 2014 at 01:34:51AM -0500, nick wrote:

> After reading the code and trying various ways to merge these
> functions into tpm.h. I am wondering if the merge is really a good
> idea as it seems to break a lot of code that is very hard to trace
> and redo correctly without a lot of work. Further more I am curious
> as to why the merge is even useful as it seems unneeded to me other
> then to unify the function definitions which seems a minor detail to
> me.

Jarkko has already sent a patch to merge them, I think you can see the
to be merged patch here:

https://github.com/PeterHuewe/linux-tpmdd/commit/6e01df24a659c5f21d6beabf9b7a20a85f470cf4

If you see a problem with it please remark..

Jason

Re: [tpmdd-devel] Question about duplicate definitions of transmit_cmd in tpm-sysfs.c and tmp-interface.c

[Jarkko Sakkinen]

On Fri, 2015-01-02 at 01:48 -0500, nick wrote:
> Jason,
> Just a little nitpick but Jarkoo seems to have missed removing the function
> prototype, tpm_transmit as nothing uses this function anymore.

tpm-dev.c does.

> Regards Nick

/Jarkko

> 
> On 2015-01-02 01:36 AM, Jason Gunthorpe wrote:
> > On Sat, Dec 27, 2014 at 01:34:51AM -0500, nick wrote:
> > 
> >> After reading the code and trying various ways to merge these
> >> functions into tpm.h. I am wondering if the merge is really a good
> >> idea as it seems to break a lot of code that is very hard to trace
> >> and redo correctly without a lot of work. Further more I am curious
> >> as to why the merge is even useful as it seems unneeded to me other
> >> then to unify the function definitions which seems a minor detail to
> >> me.
> > 
> > Jarkko has already sent a patch to merge them, I think you can see the
> > to be merged patch here:
> > 
> > https://github.com/PeterHuewe/linux-tpmdd/commit/6e01df24a659c5f21d6beabf9b7a20a85f470cf4
> > 
> > If you see a problem with it please remark..
> > 
> > Jason
> > 
> 
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming! The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net
> _______________________________________________
> tpmdd-devel mailing list
> tpmdd-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tpmdd-devel