* [PATCH] Added PIDs for Actisense USB Devices
@ 2015-01-14 13:58 Mark Glover
2015-01-14 14:56 ` Peter Stuge
0 siblings, 1 reply; 8+ messages in thread
From: Mark Glover @ 2015-01-14 13:58 UTC (permalink / raw)
To: johan, gregkh, linux-usb; +Cc: linux-kernel, Mark Glover
From: Mark Glover <mark@actisense.com>
Signed-off-by: Mark Glover <mark@actisense.com>
---
drivers/usb/serial/ftdi_sio.c | 17 +++++++++++++++++
drivers/usb/serial/ftdi_sio_ids.h | 21 +++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 1ebb351..a118e5b 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -978,6 +978,23 @@ static const struct usb_device_id id_table_combined[] = {
{ USB_DEVICE_INTERFACE_NUMBER(INFINEON_VID, INFINEON_TRIBOARD_PID, 1) },
/* GE Healthcare devices */
{ USB_DEVICE(GE_HEALTHCARE_VID, GE_HEALTHCARE_NEMO_TRACKER_PID) },
+ /* Active Research (Actisense) devices */
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NDC_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_USG_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NGT_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NGW_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AC_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AD_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AE_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AF_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEAGAUGE_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASWITCH_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_NMEA2000_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_ETHERNET_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_WIFI_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_DISPLAY_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_LITE_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_ANALOG_PID) },
{ } /* Terminating entry */
};
diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serials/ftdi_sio_ids.h
index e52409c..8ccd1b6 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -1438,3 +1438,24 @@
*/
#define GE_HEALTHCARE_VID 0x1901
#define GE_HEALTHCARE_NEMO_TRACKER_PID 0x0015
+
+/*
+ * Active Research (Actisense) devices
+ */
+#define ACTISENSE_NDC_PID 0xD9A8 /* NDC USB Serial Adapter */
+#define ACTISENSE_USG_PID 0xD9A9 /* USG USB Serial Adapter */
+#define ACTISENSE_NGT_PID 0xD9AA /* NGT NMEA2000 Interface */
+#define ACTISENSE_NGW_PID 0xD9AB /* NGW NMEA2000 Gateway */
+#define ACTISENSE_D9AC_PID 0xD9AC /* Actisense Reserved */
+#define ACTISENSE_D9AD_PID 0xD9AD /* Actisense Reserved */
+#define ACTISENSE_D9AE_PID 0xD9AE /* Actisense Reserved */
+#define ACTISENSE_D9AF_PID 0xD9AF /* Actisense Reserved */
+#define CHETCO_SEAGAUGE_PID 0xA548 /* SeaGauge USB Adapter */
+#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Apadter */
+#define CHETCO_SEASMART_NMEA2000_PID 0xA54A /* SeaSmart NMEA2000 Gateway */
+#define CHETCO_SEASMART_ETHERNET_PID 0xA54B /* SeaSmart Ethernet Gateway */
+#define CHETCO_SEASMART_WIFI_PID 0xA5AC /* SeaSmart Wifi Gateway */
+#define CHETCO_SEASMART_DISPLAY_PID 0xA5AD /* SeaSmart NMEA2000 Display */
+#define CHETCO_SEASMART_LITE_PID 0xA5AE /* SeaSmart Lite USB Adapter */
+#define CHETCO_SEASMART_ANALOG_PID 0xA5AF /* SeaSmart Analog Adapter */
+
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Added PIDs for Actisense USB Devices
2015-01-14 13:58 [PATCH] Added PIDs for Actisense USB Devices Mark Glover
@ 2015-01-14 14:56 ` Peter Stuge
0 siblings, 0 replies; 8+ messages in thread
From: Peter Stuge @ 2015-01-14 14:56 UTC (permalink / raw)
To: Mark Glover; +Cc: johan, gregkh, linux-usb, linux-kernel
Mark Glover wrote:
> From: Mark Glover <mark@actisense.com>
>
> Signed-off-by: Mark Glover <mark@actisense.com>
There's an extraneous leading whitespace on the Signed-off-by line.
> +#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Apadter */
The typo remains. "Apadter" here --------------------------------^
//Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Added PIDs for Actisense USB Devices
@ 2015-01-15 8:34 Mark Glover
2015-01-19 15:14 ` Johan Hovold
0 siblings, 1 reply; 8+ messages in thread
From: Mark Glover @ 2015-01-15 8:34 UTC (permalink / raw)
To: johan, gregkh, linux-usb; +Cc: linux-kernel, Mark Glover
From: Mark Glover <mark@actisense.com>
Signed-off-by: Mark Glover <mark@actisense.com>
---
drivers/usb/serial/ftdi_sio.c | 17 +++++++++++++++++
drivers/usb/serial/ftdi_sio_ids.h | 21 +++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 1ebb351..a118e5b 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -978,6 +978,23 @@ static const struct usb_device_id id_table_combined[] = {
{ USB_DEVICE_INTERFACE_NUMBER(INFINEON_VID, INFINEON_TRIBOARD_PID, 1) },
/* GE Healthcare devices */
{ USB_DEVICE(GE_HEALTHCARE_VID, GE_HEALTHCARE_NEMO_TRACKER_PID) },
+ /* Active Research (Actisense) devices */
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NDC_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_USG_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NGT_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NGW_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AC_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AD_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AE_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AF_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEAGAUGE_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASWITCH_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_NMEA2000_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_ETHERNET_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_WIFI_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_DISPLAY_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_LITE_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_ANALOG_PID) },
{ } /* Terminating entry */
};
diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serials/ftdi_sio_ids.h
index e52409c..8ccd1b6 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -1438,3 +1438,24 @@
*/
#define GE_HEALTHCARE_VID 0x1901
#define GE_HEALTHCARE_NEMO_TRACKER_PID 0x0015
+
+/*
+ * Active Research (Actisense) devices
+ */
+#define ACTISENSE_NDC_PID 0xD9A8 /* NDC USB Serial Adapter */
+#define ACTISENSE_USG_PID 0xD9A9 /* USG USB Serial Adapter */
+#define ACTISENSE_NGT_PID 0xD9AA /* NGT NMEA2000 Interface */
+#define ACTISENSE_NGW_PID 0xD9AB /* NGW NMEA2000 Gateway */
+#define ACTISENSE_D9AC_PID 0xD9AC /* Actisense Reserved */
+#define ACTISENSE_D9AD_PID 0xD9AD /* Actisense Reserved */
+#define ACTISENSE_D9AE_PID 0xD9AE /* Actisense Reserved */
+#define ACTISENSE_D9AF_PID 0xD9AF /* Actisense Reserved */
+#define CHETCO_SEAGAUGE_PID 0xA548 /* SeaGauge USB Adapter */
+#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Adapter */
+#define CHETCO_SEASMART_NMEA2000_PID 0xA54A /* SeaSmart NMEA2000 Gateway */
+#define CHETCO_SEASMART_ETHERNET_PID 0xA54B /* SeaSmart Ethernet Gateway */
+#define CHETCO_SEASMART_WIFI_PID 0xA5AC /* SeaSmart Wifi Gateway */
+#define CHETCO_SEASMART_DISPLAY_PID 0xA5AD /* SeaSmart NMEA2000 Display */
+#define CHETCO_SEASMART_LITE_PID 0xA5AE /* SeaSmart Lite USB Adapter */
+#define CHETCO_SEASMART_ANALOG_PID 0xA5AF /* SeaSmart Analog Adapter */
+
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Added PIDs for Actisense USB Devices
2015-01-15 8:34 [PATCH] Added PIDs for Actisense USB Devices Mark Glover
@ 2015-01-19 15:14 ` Johan Hovold
0 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2015-01-19 15:14 UTC (permalink / raw)
To: Mark Glover; +Cc: johan, gregkh, linux-usb, linux-kernel
On Thu, Jan 15, 2015 at 08:34:34AM +0000, Mark Glover wrote:
> From: Mark Glover <mark@actisense.com>
>
> Signed-off-by: Mark Glover <mark@actisense.com>
Thanks for the patch and for addressing Peter's comments.
A couple of minor nits: Please use a subsystem prefix for your patch
summary, for example:
"USB: ftdi_sio: add PIDs for Actisense devices"
You should also include a commit message (e.g. your current subject)
even if this is a simple patch.
You are adding both Actisense and Chetco product ids. How are these
related? Shouldn't the Chetco be under it's own heading (and be
mentioned in the commit log)?
And when resending, please include a "PATCH v4" prefix to make it easy
to track patch revisions.
Thanks,
Johan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Added Pids for Actisense Usb Devices
@ 2015-02-11 10:49 Mark Glover
2015-02-12 2:24 ` Johan Hovold
0 siblings, 1 reply; 8+ messages in thread
From: Mark Glover @ 2015-02-11 10:49 UTC (permalink / raw)
To: johan, gregkh, linux-usb; +Cc: linux-kernel, Mark Glover
From: Mark Glover <mark@actisense.com>
Signed-off-by: Mark Glover <mark@actisense.com>
---
drivers/usb/serial/ftdi_sio.c | 17 +++++++++++++++++
drivers/usb/serial/ftdi_sio_ids.h | 21 +++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 1ebb351..651dc1b 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -978,6 +978,23 @@ static const struct usb_device_id id_table_combined[] = {
{ USB_DEVICE_INTERFACE_NUMBER(INFINEON_VID, INFINEON_TRIBOARD_PID, 1) },
/* GE Healthcare devices */
{ USB_DEVICE(GE_HEALTHCARE_VID, GE_HEALTHCARE_NEMO_TRACKER_PID) },
+ /* Active Research (Actisense) devices */
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NDC_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_USG_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NGT_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_NGW_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AC_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AD_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AE_PID) },
+ { USB_DEVICE(FTDI_VID, ACTISENSE_D9AF_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEAGAUGE_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASWITCH_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_NMEA2000_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_ETHERNET_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_WIFI_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_DISPLAY_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_LITE_PID) },
+ { USB_DEVICE(FTDI_VID, CHETCO_SEASMART_ANALOG_PID) },
{ } /* Terminating entry */
};
diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
index e52409c..87d9ed7 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -1438,3 +1438,23 @@
*/
#define GE_HEALTHCARE_VID 0x1901
#define GE_HEALTHCARE_NEMO_TRACKER_PID 0x0015
+
+/*
+ * Active Research (Actisense) devices
+ */
+#define ACTISENSE_NDC_PID 0xD9A8 /* NDC USB Serial Adapter */
+#define ACTISENSE_USG_PID 0xD9A9 /* USG USB Serial Adapter */
+#define ACTISENSE_NGT_PID 0xD9AA /* NGT NMEA2000 Interface */
+#define ACTISENSE_NGW_PID 0xD9AB /* NGW NMEA2000 Gateway */
+#define ACTISENSE_D9AC_PID 0xD9AC /* Actisense Reserved */
+#define ACTISENSE_D9AD_PID 0xD9AD /* Actisense Reserved */
+#define ACTISENSE_D9AE_PID 0xD9AE /* Actisense Reserved */
+#define ACTISENSE_D9AF_PID 0xD9AF /* Actisense Reserved */
+#define CHETCO_SEAGAUGE_PID 0xA548 /* SeaGauge USB Adapter */
+#define CHETCO_SEASWITCH_PID 0xA549 /* SeaSwitch USB Adapter */
+#define CHETCO_SEASMART_NMEA2000_PID 0xA54A /* SeaSmart NMEA2000 Gateway */
+#define CHETCO_SEASMART_ETHERNET_PID 0xA54B /* SeaSmart Ethernet Gateway */
+#define CHETCO_SEASMART_WIFI_PID 0xA5AC /* SeaSmart Wifi Gateway */
+#define CHETCO_SEASMART_DISPLAY_PID 0xA5AD /* SeaSmart NMEA2000 Display */
+#define CHETCO_SEASMART_LITE_PID 0xA5AE /* SeaSmart Lite USB Adapter */
+#define CHETCO_SEASMART_ANALOG_PID 0xA5AF /* SeaSmart Analog Adapter */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Added Pids for Actisense Usb Devices
2015-02-11 10:49 [PATCH] Added Pids for Actisense Usb Devices Mark Glover
@ 2015-02-12 2:24 ` Johan Hovold
2015-02-12 8:46 ` Mark Glover
0 siblings, 1 reply; 8+ messages in thread
From: Johan Hovold @ 2015-02-12 2:24 UTC (permalink / raw)
To: Mark Glover; +Cc: johan, gregkh, linux-usb, linux-kernel
On Wed, Feb 11, 2015 at 10:49:47AM +0000, Mark Glover wrote:
> From: Mark Glover <mark@actisense.com>
>
> Signed-off-by: Mark Glover <mark@actisense.com>
What is different from your previous version? Please address my comments
to that one before resending.
Thanks,
Johan
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] Added Pids for Actisense Usb Devices
2015-02-12 2:24 ` Johan Hovold
@ 2015-02-12 8:46 ` Mark Glover
2015-02-12 9:42 ` Johan Hovold
0 siblings, 1 reply; 8+ messages in thread
From: Mark Glover @ 2015-02-12 8:46 UTC (permalink / raw)
To: 'Johan Hovold', 'Mark Glover'
Cc: gregkh, linux-usb, linux-kernel
Sorry, no difference just ignorance on my part.
I had the impression having just missed one release I needed to resubmit the
patch.
Best regards
Mark Glover
Software Engineer
Actisense®/Active Research Ltd
Tel:+44 (0)1202 746682
http://www.actisense.com
Active Research Limited is registered in England, Company number: 3295909.
The information contained in this e-mail is confidential and is intended for
the named recipient only. If you are not the named recipient, please notify
us by telephone on +44 1202 746682 immediately and destroy the message by
deleting it from your computer. Active Research Limited has taken every
reasonable precaution to ensure that any attachment to this e-mail has been
checked for viruses. However, we cannot accept liability for any damage
sustained as a result of any such software viruses and advise you to carry
out your own virus check before opening any attachment(s). Furthermore, we
do not accept responsibility for any change made to this message after it
was sent by the sender.
-----Original Message-----
From: Johan Hovold [mailto:jhovold@gmail.com] On Behalf Of Johan Hovold
Sent: 12 February 2015 02:24
To: Mark Glover
Cc: johan@kernel.org; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added Pids for Actisense Usb Devices
On Wed, Feb 11, 2015 at 10:49:47AM +0000, Mark Glover wrote:
> From: Mark Glover <mark@actisense.com>
>
> Signed-off-by: Mark Glover <mark@actisense.com>
What is different from your previous version? Please address my comments to
that one before resending.
Thanks,
Johan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Added Pids for Actisense Usb Devices
2015-02-12 8:46 ` Mark Glover
@ 2015-02-12 9:42 ` Johan Hovold
0 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2015-02-12 9:42 UTC (permalink / raw)
To: Mark Glover
Cc: 'Johan Hovold', 'Mark Glover', gregkh, linux-usb,
linux-kernel
On Thu, Feb 12, 2015 at 08:46:51AM -0000, Mark Glover wrote:
> Sorry, no difference just ignorance on my part.
> I had the impression having just missed one release I needed to resubmit the
> patch.
No, I'm still waiting for you to answer my comments on your patch.
Mostly some clarifications needed.
Thanks,
Johan
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-02-12 9:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 8:34 [PATCH] Added PIDs for Actisense USB Devices Mark Glover
2015-01-19 15:14 ` Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2015-02-11 10:49 [PATCH] Added Pids for Actisense Usb Devices Mark Glover
2015-02-12 2:24 ` Johan Hovold
2015-02-12 8:46 ` Mark Glover
2015-02-12 9:42 ` Johan Hovold
2015-01-14 13:58 [PATCH] Added PIDs for Actisense USB Devices Mark Glover
2015-01-14 14:56 ` Peter Stuge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox