From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbbAOJDW (ORCPT ); Thu, 15 Jan 2015 04:03:22 -0500 Received: from mga01.intel.com ([192.55.52.88]:25761 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbbAOJDT (ORCPT ); Thu, 15 Jan 2015 04:03:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,402,1418112000"; d="asc'?scan'208";a="662210484" Message-ID: <1421312596.2632.3.camel@jtkirshe-mobl> Subject: Re: [linux-nics] [PATCHv4 net] i40e: Implement ndo_gso_check() From: Jeff Kirsher To: Jesse Gross Cc: Joe Stringer , netdev , "linux.nics" , Linux Kernel Mailing List , Tom Herbert Date: Thu, 15 Jan 2015 01:03:16 -0800 In-Reply-To: References: <1417804872-58635-1-git-send-email-joestringer@nicira.com> <1417806738.2404.42.camel@jtkirshe-mobl> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-bdIHet2La4Nb+nPyLShL" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-bdIHet2La4Nb+nPyLShL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-01-14 at 18:24 -0800, Jesse Gross wrote: > On Fri, Dec 26, 2014 at 3:58 PM, Jesse Gross wrote: > > On Fri, Dec 5, 2014 at 2:12 PM, Jeff Kirsher > > wrote: > >> On Fri, 2014-12-05 at 10:41 -0800, Joe Stringer wrote: > >>> ndo_gso_check() was recently introduced to allow NICs to report the > >>> offloading support that they have on a per-skb basis. Add an > >>> implementation for this driver which checks for IPIP, GRE, UDP > >>> tunnels. > >>> > >>> Signed-off-by: Joe Stringer > >>> --- > >>> v4: Simplify the check to just do tunnel header length. > >>> Fix #define style issue. > >>> v3: Drop IPIP and GRE (no driver support even though hw supports it). > >>> Check for UDP outer protocol for UDP tunnels. > >>> v2: Expand to include IP in IP and IPv4/IPv6 inside GRE/UDP tunnels. > >>> Add MAX_INNER_LENGTH (as 80). > >>> --- > >>> drivers/net/ethernet/intel/i40e/i40e_main.c | 12 ++++++++++++ > >>> 1 file changed, 12 insertions(+) > >> > >> Thanks Joe, I will update the patch in my queue with your latest > >> version. > > > > Jeff, as a heads-up, this patch and the corresponding one for fm10k > > will no longer apply now that the ndo has changed. This was changed by > > 5f35227e ("net: Generalize ndo_gso_check to ndo_features_check"). The > > update needed is trivial and is just due to the change in the function > > signature but I'm not sure where you are in the testing process with > > this. >=20 > Jeff - just wanted to check if you had seen this. Yeah, I have the updated patch in my queue. I was hoping to get this patch pushed later this week. It did not make the series of i40e patches I am preparing to send out in the next couple of hours, but should be in the next series or the series following the next. Holidays put a damper on things unfortunately. --=-bdIHet2La4Nb+nPyLShL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJUt4JUAAoJEOVv75VaS+3OqmQQAJ26GSsuG4RAMPzrsvKvoklt voz1xMTPhp0CCJmgwzpr9J7Zw7+7OwmNMmzZRmE4J27cqNgbAGoTwybMcnK4oC6f LxuUMUsqS26Sb/XM6QUC39sinKxgpe8ZpuHI05IUug3p+TwlWhYalwcjApP/YLyR 5rrC9eBPHU1LcuroPuM2ERRfMUdEwtrGI9gt3SETHnqFNaaEgwlO4TJbzznHQ+2R jamOjgZ8AGm1wuhFr/xIRfxISvargtP3DlDKTvb12psbOW7EWPWTsY/8KG6Y3SrE p20UTR6BU0Jq5O69lU5U7MvPQLFi8PkkPrPTYK8S0mnB5rICFEA00KJ9xdlQL8Z2 gCrMCyK6c9yUfH9/HUNOcoD5kFwIIB9Ousc78LKUBOsoUQVdjvb9fqo5CNiAwI9s kZ9FSb3G3dKhxLiE9Y42Q8RueUNT7TaRTnBPsbcFfpK8DIP9VRAcPiCaP0kNdu8c LpBCuZEubMdWz0uL60edTaiZblDzoZT+2mCGad66tRhuyCm24L8XVeM096xs7aqG WtPiFmdr86K6pMagVV4XFa6Cr6RupaWdFkj/G8ar7MuWnKNDMGKYsgnp+KsGx9Lo 3fNHbEOOuan91LWCqEGTrsD+h8mt29puW3JY2oiMeZdKFZrhaAG0gRMF2uSORl3T AQMxFUjdGIxpUXpUOy1l =Vb8j -----END PGP SIGNATURE----- --=-bdIHet2La4Nb+nPyLShL--