linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David E. Box" <david.e.box@linux.intel.com>
To: wsa@the-dreams.de
Cc: jdelvare@suse.de, arnd@arndb.de,
	maxime.ripard@free-electrons.com, dianders@chromium.org,
	david.e.box@linux.intel.com, u.kleine-koenig@pengutronix.de,
	laurent.pinchart+renesas@ideasonboard.com,
	boris.brezillon@free-electrons.com, maxime.coquelin@st.com,
	andrew@lunn.ch, sjg@chromium.org, markus.mayer@linaro.org,
	ch.naveen@samsung.com, jacob.jun.pan@linux.intel.com,
	max.schwarz@online.de, mika.westerberg@linux.intel.com,
	skuribay@pobox.com, Romain.Baeriswyl@abilis.com,
	wenkai.du@intel.com, christian.ruppert@abilis.com,
	alan@linux.intel.com, linux-kernel@vger.kernel.org,
	linux-i2c@vger.kernel.org
Subject: [PATCH V4 0/2] i2c-designware: Add Intel Baytrail pmic i2c bus support
Date: Thu, 15 Jan 2015 01:12:15 -0800	[thread overview]
Message-ID: <1421313137-1613-1-git-send-email-david.e.box@linux.intel.com> (raw)
In-Reply-To: <1417478973-25522-1-git-send-email-david.e.box@linux.intel.com>

V4:	- Added bus lock to i2c_dw_init() as suggested by Jarrko Nikula
	  <jarkko.nikula@linux.intel.com>. Addresses infrequent hang that was
	  seen occuring during probe.
	- Added label in i2c_dw_xfer() to bypass unnecessary lock release when
	  acquire fails. Suggested by Mika.
	- Changed make to build driver as composite addition to
	  i2c-designware-platform. Driver can be module or built-in following
	  the platform driver selection. Tested as both.
	- Added EPROBE_DEFER return to baytrail definition of i2c_dw_eval_lock()
	  to defer probe if iosf_mbi driver (required for acquring bus lock) is
	  not available.

V3:	- Split lock support and driver into separate patches
	- Change module build to bool. Platforms running without this driver
	  cannot perform critical functions such as charging. Furthermore attempts
	  by other drivers to access the i2c bus without a lock will hang the
	  platform.
	- Replaced has_hw_lock flag with acquire/release function pointers.
	- Replaced acquire/release ifdef code with single
	  i2c_dw_eval_lock_support() test for cleaner (if still undesirable)
	  compile time scalability. Future Intel platforms will however continue
	  to use the Baytrail driver.

V2:	- Moved semaphore detection out of dw platform driver
	- Replaced function pointers with defined acquire/release functions in
	  dw core. This helps eliminate the ifdefery in the dw platform driver.
	- Use new has_hw_lock flag to check if the lock exists on a given bus.
	- Use new pm_runtime_disabled flag to conditionally turnoff runtime pm
	  in the dw platform driver.

David E. Box (2):
  i2c-designware: Add i2c bus locking support
  i2c-designware: Add Intel Baytrail PMIC I2C bus support

 drivers/i2c/busses/Kconfig                   |  11 ++
 drivers/i2c/busses/Makefile                  |   1 +
 drivers/i2c/busses/i2c-designware-baytrail.c | 160 +++++++++++++++++++++++++++
 drivers/i2c/busses/i2c-designware-core.c     |  26 +++++
 drivers/i2c/busses/i2c-designware-core.h     |  12 ++
 drivers/i2c/busses/i2c-designware-platdrv.c  |  20 +++-
 6 files changed, 225 insertions(+), 5 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-designware-baytrail.c

-- 
1.9.1


  parent reply	other threads:[~2015-01-15  9:16 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12 17:36 [PATCH] i2c-designware: Intel BayTrail PMIC I2C bus support David E. Box
2014-09-15  6:57 ` Maxime Coquelin
2014-09-15 16:55   ` David E. Box
2014-09-16  9:44 ` Mika Westerberg
2014-09-16 10:53   ` Jacob Pan
2014-09-16 10:58     ` Mika Westerberg
2014-09-17  4:01   ` Li, Aubrey
2014-09-17 11:02 ` One Thousand Gnomes
2014-09-23 18:40 ` [PATCH V2] i2c-designware: Add Intel Baytrail " David E. Box
2014-09-23 19:00   ` Maxime Ripard
2014-09-23 19:58     ` David E. Box
2014-09-25  9:47       ` Maxime Ripard
     [not found]         ` <20141007191420.GA25126@pathfinder>
2014-10-09 12:36           ` Maxime Ripard
2014-11-11 11:32   ` Wolfram Sang
2014-11-11 17:11     ` David E. Box
2014-11-11 11:50   ` Mika Westerberg
2014-12-02  0:09   ` [PATCH V3 0/2] i2c-designware: Baytrail bus locking driver David E. Box
2014-12-02  0:09     ` [PATCH V3 1/2] i2c-designware: Add i2c bus locking support David E. Box
2014-12-03 16:01       ` Mika Westerberg
2014-12-04 18:49         ` David E. Box
2014-12-04  7:59       ` Jarkko Nikula
2014-12-04 18:42         ` David E. Box
2015-01-13  9:48           ` Wolfram Sang
2015-01-14 18:15             ` David E. Box
2014-12-02  0:09     ` [PATCH V3 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support David E. Box
2014-12-03 16:10       ` Mika Westerberg
2014-12-04 19:11         ` David E. Box
2014-12-06  3:51     ` [PATCH V3 0/2] i2c-designware: Baytrail bus locking driver Shinya Kuribayashi
2015-01-15  9:12     ` David E. Box [this message]
2015-01-26 11:27       ` [PATCH V4 0/2] i2c-designware: Add Intel Baytrail pmic i2c bus support Wolfram Sang
2015-01-15  9:12     ` [PATCH V4 1/2] i2c-designware: Add i2c bus locking support David E. Box
2015-01-22 14:22       ` Mika Westerberg
2015-01-15  9:12     ` [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support David E. Box
2015-01-22 14:28       ` Mika Westerberg
2015-01-22 20:48         ` David E. Box
2015-01-23  9:32           ` Mika Westerberg
2015-01-23 14:18       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421313137-1613-1-git-send-email-david.e.box@linux.intel.com \
    --to=david.e.box@linux.intel.com \
    --cc=Romain.Baeriswyl@abilis.com \
    --cc=alan@linux.intel.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=boris.brezillon@free-electrons.com \
    --cc=ch.naveen@samsung.com \
    --cc=christian.ruppert@abilis.com \
    --cc=dianders@chromium.org \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=jdelvare@suse.de \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.mayer@linaro.org \
    --cc=max.schwarz@online.de \
    --cc=maxime.coquelin@st.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sjg@chromium.org \
    --cc=skuribay@pobox.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wenkai.du@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).