public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Kent <ikent@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>,
	Oleg Nesterov <onestero@redhat.com>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Benjamin Coddington <bcodding@redhat.com>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	Jeff Layton <jeff.layton@primarydata.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [RFC PATCH 0/5] Second attempt at contained helper execution
Date: Fri, 16 Jan 2015 09:01:13 +0800	[thread overview]
Message-ID: <1421370073.2630.4.camel@pluto.fritz.box> (raw)
In-Reply-To: <20150115162741.GA14902@fieldses.org>

On Thu, 2015-01-15 at 11:27 -0500, J. Bruce Fields wrote:
> On Thu, Jan 15, 2015 at 08:26:12AM +0800, Ian Kent wrote:
> > On Wed, 2015-01-14 at 17:10 -0500, J. Bruce Fields wrote:
> > > > On Wed, Jan 14, 2015 at 05:32:22PM +0800, Ian Kent wrote:
> > > > > There are other difficulties to tackle as well, such as how to decide
> > > > > if contained helper execution is needed. For example, if a mount has
> > > > > been propagated to a container or bound into the container tree (such
> > > > > as with the --volume option of "docker run") the root init namespace
> > > > > may need to be used and not the container namespace.
> > > 
> > > I think you have to go through each of the existing upcall examples and
> > > decide what's needed for each.
> > > 
> > > At least for the nfsv4 idmapper I would've thought the namespace the
> > > mount was done in would be the right choice, hence my previous question.
> > 
> > Probably but you don't necessarily know what namespace the mount was
> > done in. It may have been propagated from another namespace or (although
> > I don't think it works yet) bound from another container using the
> > volumes-from docker option.
> 
> Name-id mappings should be associated with the superblock, I guess--so
> don't you store a pointer to the right thing there?

Quite possibly but my original point was, without an acceptable
mechanism to execute the helper we can't know what might need to be done
to use it.

> 
> --b.
> 
> > 
> > At least I believe that's a problem and I agree that, once a suitable
> > method of running helpers is found each case will need to be looked at.
> > 
> > Ian
> > 
> > 



  reply	other threads:[~2015-01-16  1:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14  9:32 [RFC PATCH 0/5] Second attempt at contained helper execution Ian Kent
2015-01-14  9:32 ` [RFC PATCH 1/5] nsproxy - refactor setns() Ian Kent
2015-01-14  9:32 ` [RFC PATCH 2/5] kmod - rename call_usermodehelper() flags parameter Ian Kent
2015-01-14  9:32 ` [RFC PATCH 3/5] kmod - teach call_usermodehelper() to use a namespace Ian Kent
2015-01-15 16:45   ` Jeff Layton
2015-01-16  1:18     ` Ian Kent
2015-01-14  9:32 ` [RFC PATCH 4/5] KEYS - rename call_usermodehelper_keys() flags parameter Ian Kent
2015-01-14  9:32 ` [RFC PATCH 5/5] KEYS: exec request-key within the requesting task's init namespace Ian Kent
2015-01-14 21:55 ` [RFC PATCH 0/5] Second attempt at contained helper execution J. Bruce Fields
2015-01-14 22:10   ` J. Bruce Fields
2015-01-15  0:26     ` Ian Kent
2015-01-15 16:27       ` J. Bruce Fields
2015-01-16  1:01         ` Ian Kent [this message]
2015-01-16 15:25           ` J. Bruce Fields
2015-01-21  7:05             ` Ian Kent
2015-01-21 14:38               ` J. Bruce Fields
2015-01-22  1:28                 ` Ian Kent
2015-02-18 20:44                   ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421370073.2630.4.camel@pluto.fritz.box \
    --to=ikent@redhat.com \
    --cc=bcodding@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=jeff.layton@primarydata.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=onestero@redhat.com \
    --cc=trond.myklebust@primarydata.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox