From: Joe Perches <joe@perches.com>
To: Sergey Dyasly <dserrg@gmail.com>
Cc: linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: add check for the buggy while_each_thread()
Date: Sun, 18 Jan 2015 17:27:33 -0800 [thread overview]
Message-ID: <1421630853.29879.10.camel@perches.com> (raw)
In-Reply-To: <1421591040-4892-1-git-send-email-dserrg@gmail.com>
On Sun, 2015-01-18 at 17:24 +0300, Sergey Dyasly wrote:
> Now it's preferable to use for_each_thread() instead of while_each_thread().
> Add a check to checkpatch.pl in order to prevent any new usages of the buggy
> while_each_thread() when possible.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3255,6 +3255,12 @@ sub process {
> "Prefer dev_$level(... to dev_printk(KERN_$orig, ...\n" . $herecurr);
> }
>
> +# Check for the buggy while_each_thread()
> + if ($line =~ /\bwhile_each_thread\(/) {
\bwhile_each_thread\s*\(
or maybe
\bwhile_each_thread\b
> + WARN("WHILE_EACH_THREAD",
> + "Prefer to use for_each_thread() instead of the buggy while_each_thread(). See commit 0c740d0afc3bff0a097ad03a1c8df92757516f5c for details.\n" . $herecurr);
Pretty long commit id, 12 is probably enough.
next prev parent reply other threads:[~2015-01-19 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 14:24 [PATCH] checkpatch: add check for the buggy while_each_thread() Sergey Dyasly
2015-01-19 1:27 ` Joe Perches [this message]
2015-01-21 16:35 ` Sergey Dyasly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421630853.29879.10.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dserrg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox