From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: Kevin Hilman <khilman@kernel.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linaro-kernel@lists.linaro.org,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
Date: Tue, 20 Jan 2015 10:19:46 +0100 [thread overview]
Message-ID: <1421745586.6818.34.camel@collabora.co.uk> (raw)
In-Reply-To: <1421284089-421-1-git-send-email-khilman@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2598 bytes --]
On Wed, 2015-01-14 at 17:08 -0800, Kevin Hilman wrote:
> From: Kevin Hilman <khilman@linaro.org>
>
> The odroid-xu3 has 4 INA231 current sensors on board which can be
> accessed from the Linux via the hwmon interface.
>
> There is one sensor for each of these power rails:
>
> - A15 cluster: VDD_ARM
> - A7 cluster: VDD_KFC
> - GPU: VDD_G3D
> - memory: VDD_MEM
>
> In addition to adding the sensors, LDO26 from the PMIC needs to be
> enabled because it's powering these sensor.
I haven't tested whether the sensor values are correct, but based on the
schematics & the hardkernel dts this describes the hardware correctly.
Reviewed-By: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> v2: use "ti,ina231" as compatible string.
>
> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd Simons.
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index c29123c0734d..50353d023225 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -174,6 +174,13 @@
> regulator-always-on;
> };
>
> + ldo26_reg: LDO26 {
> + regulator-name = "vdd_ldo26";
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-always-on;
> + };
> +
> buck1_reg: BUCK1 {
> regulator-name = "vdd_mif";
> regulator-min-microvolt = <800000>;
> @@ -257,6 +264,38 @@
> };
> };
>
> + i2c_0: i2c@12C60000 {
> + status = "okay";
> +
> + /* A15 cluster: VDD_ARM */
> + ina231@40 {
> + compatible = "ti,ina231";
> + reg = <0x40>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* memory: VDD_MEM */
> + ina231@41 {
> + compatible = "ti,ina231";
> + reg = <0x41>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* GPU: VDD_G3D */
> + ina231@44 {
> + compatible = "ti,ina231";
> + reg = <0x44>;
> + shunt-resistor = <10000>;
> + };
> +
> + /* A7 cluster: VDD_KFC */
> + ina231@45 {
> + compatible = "ti,ina231";
> + reg = <0x45>;
> + shunt-resistor = <10000>;
> + };
> + };
> +
> i2c_2: i2c@12C80000 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <66000>;
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6170 bytes --]
next prev parent reply other threads:[~2015-01-20 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 1:08 [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors Kevin Hilman
2015-01-20 9:19 ` Sjoerd Simons [this message]
2015-01-21 2:54 ` Joonyoung Shim
2015-01-22 19:47 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421745586.6818.34.camel@collabora.co.uk \
--to=sjoerd.simons@collabora.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox