From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754674AbbATQ1P (ORCPT ); Tue, 20 Jan 2015 11:27:15 -0500 Received: from mga01.intel.com ([192.55.52.88]:3914 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283AbbATQ1O (ORCPT ); Tue, 20 Jan 2015 11:27:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,434,1418112000"; d="scan'208";a="639913471" From: "Shevchenko, Andriy" To: "lee.jones@linaro.org" CC: "mturquette@linaro.org" , "sameo@linux.intel.com" , "linux-kernel@vger.kernel.org" , "Chen, Alvin" , "Tan, Raymond" Subject: Re: [PATCH v3 1/1] mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver Thread-Topic: [PATCH v3 1/1] mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver Thread-Index: AQHQNK9KkoFpvfa40kexjfgJp3n0NpzJKZXpgAAES4A= Date: Tue, 20 Jan 2015 16:10:31 +0000 Message-ID: <1421770235.31903.95.camel@intel.com> References: <1418290710-5871-1-git-send-email-raymond.tan@intel.com> <1418290710-5871-2-git-send-email-raymond.tan@intel.com> <20150120124745.GE13701@x1> <1421761312.31903.64.camel@intel.com> <20150120155453.GJ13701@x1> In-Reply-To: <20150120155453.GJ13701@x1> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.72.90] Content-Type: text/plain; charset="utf-8" Content-ID: <8C734114856D1B4199CF5E19CD148945@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t0KGRJma013657 On Tue, 2015-01-20 at 15:54 +0000, Lee Jones wrote: > On Tue, 20 Jan 2015, Shevchenko, Andriy wrote: > > > On Tue, 2015-01-20 at 12:47 +0000, Lee Jones wrote: > > > On Thu, 11 Dec 2014, Raymond Tan wrote: > > > > [] > > > > > > +static const struct i2c_mode_info platform_i2c_mode_info[] = { > > > > + { > > > > + .name = "Galileo", > > > > + .i2c_scl_freq = 100000, > > > > + }, > > > > + { > > > > + .name = "GalileoGen2", > > > > + .i2c_scl_freq = 400000, > > > > + }, > > > > +}; > > > > > > We normally do not capitalise device names. > > > > This comes from DMI, so, can't be altered I suppose. > > I'm not sure what that means, but sounds reasonable. http://en.wikipedia.org/wiki/Desktop_Management_Interface In short, it comes from firmware that's why we have to use exact names here. -- Andy Shevchenko Intel Finland Oy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I