From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752747AbbAUH7g (ORCPT <rfc822;w@1wt.eu>);
	Wed, 21 Jan 2015 02:59:36 -0500
Received: from mailout2.w1.samsung.com ([210.118.77.12]:11366 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750888AbbAUH71 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 21 Jan 2015 02:59:27 -0500
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
X-AuditID: cbfec7f4-b7f126d000001e9a-79-54bf5c5d80fc
Content-transfer-encoding: 8BIT
Message-id: <1421827163.4420.4.camel@AMDC1943>
Subject: Re: [PATCH] power: max77693: fix simple_return.cocci warnings
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Wed, 21 Jan 2015 08:59:23 +0100
In-reply-to: <20150121041134.GA205386@athens>
References: <201501211232.F4NwbEWo%fengguang.wu@intel.com>
 <20150121041134.GA205386@athens>
X-Mailer: Evolution 3.10.4-0ubuntu2
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRmVeSWpSXmKPExsVy+t/xK7qxMftDDN5v4rWY9OQ9s8XElZOZ
	Ld4/X89scez6RGaLy7vmsFl87j3CaHF6d4kDu8f9veweO2fdZffYvELLY/Gel0wem1Z1snl8
	3iQXwBbFZZOSmpNZllqkb5fAldF9ZxtrwQ/2iuc78xoY97J1MXJySAiYSFy8+JoZwhaTuHBv
	PVhcSGApo8SWmXwgNq+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmrcIqJULqPwzo8Ta/iss
	EPV6Evsan7KC2MICbhJHH28Em8kmYCyxefkSMFsEqGbFwjZGkGZmgXOMEjs2vWAHSbAIqErM
	P3MErIhTQFfiyvGZzBAHxUrMnHCAFeQICQFlicZ+twmMArOQnDcL4bxZSM5bwMi8ilE0tTS5
	oDgpPddQrzgxt7g0L10vOT93EyMkxL/sYFx8zOoQowAHoxIPb0Xo/hAh1sSy4srcQ4wSHMxK
	IryKEkAh3pTEyqrUovz4otKc1OJDjEwcnFINjGHvKk2jDWvPnTYPKVJ3vrLxOf99+7MsN57c
	vzXl9FTDZdv23xFySbBLZ02cb6ebavD5pJnSzfN/VDcXSxdsmFZUOjdv6Rphv8o8yT9CLocW
	dP/bfGljBGPyw1/XOuLVPKpqOI5v3zzpUCaHVsbipsPl3wolGi2DtYQfdoZX6X/12dXkvK+9
	VImlOCPRUIu5qDgRAHE6+yVPAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On śro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote:
> drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  max77693_charger.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

> 
> --- a/drivers/power/max77693_charger.c
> +++ b/drivers/power/max77693_charger.c
> @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7
>  	if (ret)
>  		return ret;
>  
> -	ret = max77693_set_charge_input_threshold_volt(chg,
> +	return max77693_set_charge_input_threshold_volt(chg,
>  			chg->charge_input_threshold_volt);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
>  }
>  
>  #ifdef CONFIG_OF