public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: Juergen Gross <jgross@suse.com>
Cc: hpa@zytor.com, x86@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, linux-kernel@vger.kernel.org,
	steven@uplinklabs.net
Subject: Re: [PATCH] x86: change cachemode symbols to non-gpl to avoid breaking out-of-tree modules
Date: Thu, 22 Jan 2015 12:38:10 -0700	[thread overview]
Message-ID: <1421955490.2493.9.camel@misato.fc.hp.com> (raw)
In-Reply-To: <1421926997-28615-1-git-send-email-jgross@suse.com>

On Thu, 2015-01-22 at 12:43 +0100, Juergen Gross wrote:
> Commit 281d4078bec366d60990add9d91a952953bd0d72 ("x86: Make page
> cache mode a real type") introduced the symbols __cachemode2pte_tbl
> and __pte2cachemode_tbl and exported them via EXPORT_SYMBOL_GPL.
> This will break building out-of-tree non-gpl modules which need to
> set caching mode in ptes.
> 
> Change EXPORT_SYMBOL_GPL to EXPORT-SYMBOL for these two symbols.
> 
> Reported-by: Stevan Noonan <steven@uplinklabs.net>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Toshi Kani <toshi.kani@hp.com>

-Toshi

> ---
>  arch/x86/mm/init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index 08a7d31..079c3b6 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -43,7 +43,7 @@ uint16_t __cachemode2pte_tbl[_PAGE_CACHE_MODE_NUM] = {
>  	[_PAGE_CACHE_MODE_WT]		= _PAGE_PCD,
>  	[_PAGE_CACHE_MODE_WP]		= _PAGE_PCD,
>  };
> -EXPORT_SYMBOL_GPL(__cachemode2pte_tbl);
> +EXPORT_SYMBOL(__cachemode2pte_tbl);
>  uint8_t __pte2cachemode_tbl[8] = {
>  	[__pte2cm_idx(0)] = _PAGE_CACHE_MODE_WB,
>  	[__pte2cm_idx(_PAGE_PWT)] = _PAGE_CACHE_MODE_WC,
> @@ -54,7 +54,7 @@ uint8_t __pte2cachemode_tbl[8] = {
>  	[__pte2cm_idx(_PAGE_PCD | _PAGE_PAT)] = _PAGE_CACHE_MODE_UC_MINUS,
>  	[__pte2cm_idx(_PAGE_PWT | _PAGE_PCD | _PAGE_PAT)] = _PAGE_CACHE_MODE_UC,
>  };
> -EXPORT_SYMBOL_GPL(__pte2cachemode_tbl);
> +EXPORT_SYMBOL(__pte2cachemode_tbl);
>  
>  static unsigned long __initdata pgt_buf_start;
>  static unsigned long __initdata pgt_buf_end;



  parent reply	other threads:[~2015-01-22 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 11:43 [PATCH] x86: change cachemode symbols to non-gpl to avoid breaking out-of-tree modules Juergen Gross
2015-01-22 13:49 ` Steven Noonan
2015-01-22 19:38 ` Toshi Kani [this message]
2015-01-22 20:55 ` [tip:x86/urgent] x86, mm: Change cachemode exports to non-gpl tip-bot for Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421955490.2493.9.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=steven@uplinklabs.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox