* [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf
@ 2015-01-28 14:05 Heba Aamer
2015-01-28 18:51 ` Greg KH
2015-01-29 1:56 ` Joe Perches
0 siblings, 2 replies; 4+ messages in thread
From: Heba Aamer @ 2015-01-28 14:05 UTC (permalink / raw)
To: devel
Cc: oleg.drokin, andreas.dilger, gregkh, gdonald, dmitry.eremin,
brilliantov, tristan, HPDD-discuss, linux-kernel
This patch fixes the following checkpatch.pl warning:
Prefer seq_puts to seq_printf
Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
---
drivers/staging/lustre/lustre/osc/lproc_osc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
index 8e22e45..4da837e 100644
--- a/drivers/staging/lustre/lustre/osc/lproc_osc.c
+++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c
@@ -364,7 +364,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
else
seq_printf(m, "%s ", cksum_name[i]);
}
- seq_printf(m, "\n");
+ seq_puts(m, "\n");
return 0;
}
@@ -601,7 +601,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
seq_printf(seq, "pending read pages: %d\n",
atomic_read(&cli->cl_pending_r_pages));
- seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+ seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
seq_printf(seq, "pages per rpc rpcs %% cum %% |");
seq_printf(seq, " rpcs %% cum %%\n");
@@ -624,7 +624,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
break;
}
- seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+ seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
seq_printf(seq, "rpcs in flight rpcs %% cum %% |");
seq_printf(seq, " rpcs %% cum %%\n");
@@ -647,7 +647,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
break;
}
- seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+ seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
seq_printf(seq, "offset rpcs %% cum %% |");
seq_printf(seq, " rpcs %% cum %%\n");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf
2015-01-28 14:05 [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf Heba Aamer
@ 2015-01-28 18:51 ` Greg KH
2015-01-29 1:56 ` Joe Perches
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2015-01-28 18:51 UTC (permalink / raw)
To: Heba Aamer
Cc: devel, dmitry.eremin, tristan, andreas.dilger, brilliantov,
linux-kernel, oleg.drokin, gdonald, HPDD-discuss
On Wed, Jan 28, 2015 at 04:05:33PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> Prefer seq_puts to seq_printf
>
> Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> ---
> drivers/staging/lustre/lustre/osc/lproc_osc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
> index 8e22e45..4da837e 100644
> --- a/drivers/staging/lustre/lustre/osc/lproc_osc.c
> +++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c
> @@ -364,7 +364,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
> else
> seq_printf(m, "%s ", cksum_name[i]);
> }
> - seq_printf(m, "\n");
> + seq_puts(m, "\n");
I don't think this is a straight search/replace issue, but:
> return 0;
> }
>
> @@ -601,7 +601,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
> seq_printf(seq, "pending read pages: %d\n",
> atomic_read(&cli->cl_pending_r_pages));
>
> - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
> seq_printf(seq, "pages per rpc rpcs %% cum %% |");
> seq_printf(seq, " rpcs %% cum %%\n");
if it were, why didn't you fix the other uses here?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf
2015-01-28 14:05 [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf Heba Aamer
2015-01-28 18:51 ` Greg KH
@ 2015-01-29 1:56 ` Joe Perches
2015-01-29 22:47 ` Heba Aamer
1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2015-01-29 1:56 UTC (permalink / raw)
To: Heba Aamer
Cc: devel, oleg.drokin, andreas.dilger, gregkh, gdonald,
dmitry.eremin, brilliantov, tristan, HPDD-discuss, linux-kernel
On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> Prefer seq_puts to seq_printf
checkpatch is pretty stupid.
Please don't just do what it says.
Look further and see what else can be improved.
> diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
[]
> @@ -364,7 +364,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
> else
> seq_printf(m, "%s ", cksum_name[i]);
> }
> - seq_printf(m, "\n");
> + seq_puts(m, "\n");
This could be seq_putc
> @@ -601,7 +601,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
> seq_printf(seq, "pending read pages: %d\n",
> atomic_read(&cli->cl_pending_r_pages));
>
> - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
> seq_printf(seq, "pages per rpc rpcs %% cum %% |");
> seq_printf(seq, " rpcs %% cum %%\n");
The seq_printf uses with %% could also be seq_puts
> @@ -624,7 +624,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
> break;
> }
>
> - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
> seq_printf(seq, "rpcs in flight rpcs %% cum %% |");
> seq_printf(seq, " rpcs %% cum %%\n");
seq_puts here too
> @@ -647,7 +647,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
> break;
> }
>
> - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
> seq_printf(seq, "offset rpcs %% cum %% |");
> seq_printf(seq, " rpcs %% cum %%\n");
>
and here
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf
2015-01-29 1:56 ` Joe Perches
@ 2015-01-29 22:47 ` Heba Aamer
0 siblings, 0 replies; 4+ messages in thread
From: Heba Aamer @ 2015-01-29 22:47 UTC (permalink / raw)
To: Joe Perches
Cc: devel, oleg.drokin, andreas.dilger, gregkh, gdonald,
dmitry.eremin, brilliantov, tristan, HPDD-discuss, linux-kernel
On Wed, Jan 28, 2015 at 05:56:07PM -0800, Joe Perches wrote:
> On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote:
> > This patch fixes the following checkpatch.pl warning:
> > Prefer seq_puts to seq_printf
>
> checkpatch is pretty stupid.
> Please don't just do what it says.
I checked checkpatch script and I found it only searches
for a % in order not to give that warning, and it does not
consider its escaping case %%.
>
> Look further and see what else can be improved.
I will make a new patch modifying all the seq_printf statements
in that file soon.
Regards,
Heba Aamer
>
> > diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
> []
> > @@ -364,7 +364,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
> > else
> > seq_printf(m, "%s ", cksum_name[i]);
> > }
> > - seq_printf(m, "\n");
> > + seq_puts(m, "\n");
>
> This could be seq_putc
>
> > @@ -601,7 +601,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
> > seq_printf(seq, "pending read pages: %d\n",
> > atomic_read(&cli->cl_pending_r_pages));
> >
> > - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> > + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
> > seq_printf(seq, "pages per rpc rpcs %% cum %% |");
> > seq_printf(seq, " rpcs %% cum %%\n");
>
> The seq_printf uses with %% could also be seq_puts
>
> > @@ -624,7 +624,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
> > break;
> > }
> >
> > - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> > + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
> > seq_printf(seq, "rpcs in flight rpcs %% cum %% |");
> > seq_printf(seq, " rpcs %% cum %%\n");
>
> seq_puts here too
>
> > @@ -647,7 +647,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
> > break;
> > }
> >
> > - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> > + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
> > seq_printf(seq, "offset rpcs %% cum %% |");
> > seq_printf(seq, " rpcs %% cum %%\n");
> >
>
> and here
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-29 22:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-28 14:05 [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf Heba Aamer
2015-01-28 18:51 ` Greg KH
2015-01-29 1:56 ` Joe Perches
2015-01-29 22:47 ` Heba Aamer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox